[Laszlo-dev] For Review: Change 20070913-maxcarlson-o Summary: Fix inputtext height measurement

Max Carlson max at openlaszlo.org
Thu Sep 13 11:59:18 PDT 2007


Change 20070913-maxcarlson-o by maxcarlson at plastik on 2007-09-13  
11:25:21 PDT
     in /Users/maxcarlson/openlaszlo/legals
     for http://svn.openlaszlo.org/openlaszlo/branches/legals

Summary: Fix inputtext height measurement

New Features:

Bugs Fixed: LPP-4658 - DHTML inputtext is the incorrect height

Technical Reviewer: promanik
QA Reviewer: hminsky
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details: LzSprite.js - Add text_measurement_use_insertadjacenthtml  
quirk and turn it on for IE.  Clean up testing to prevent  
LzModeManager and LzKeyboardKernel exceptions when applications are  
loaded or unloaded and the keyboard and mouse are active.

LzTextSprite.js - getTextSize() now does all text measurement inside  
a div, rather than attaching to the body and uses the   
text_measurement_use_insertadjacenthtml quirk.

LzInputTextSprite.js - Add getTextHeight() implementation to ensure  
correct heights are reported.

Tests: http://localhost:8080/legals/test/lztest/lztest-textheight.lzx? 
lzr=dhtml&debug=true runs as before, and tabbing into and out of the  
inputtext in http://localhost:8080/legals/examples/components/ 
style_example.lzx?lzt=html&lzr=dhtml no longer causes it to resize.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070913- 
maxcarlson-o.tar


More information about the Laszlo-dev mailing list