[Laszlo-dev] For Review: Change 20070906-maxcarlson-V Summary: Fix possible null dereference in FileUtils.stripByteOrderMark()

P T Withington ptw at openlaszlo.org
Fri Sep 7 04:24:36 PDT 2007


Er, my momma always told me that it was a bad idea to catch and  
ignore random errors.  Couldn't you achieve the same effect by  
checking .length before poking at the bytes?

On 2007-09-06, at 16:03 EDT, Max Carlson wrote:

> Change 20070906-maxcarlson-V by maxcarlson at plastik on 2007-09-06  
> 13:00:25 PDT
>     in /Users/maxcarlson/openlaszlo/waffleconeclean
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Fix possible null dereference in  
> FileUtils.stripByteOrderMark()
>
> New Features:
>
> Bugs Fixed: LPP-4583 - Improve compiler and caching performance
>
> Technical Reviewer: promanik
> QA Reviewer: ptw
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: Prevent a possible null dereference in stripByteOrderMark 
> () by adding a try/catch statement.
>
>
> Tests: IWFM
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/utils/FileUtils.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070906- 
> maxcarlson-V.tar



More information about the Laszlo-dev mailing list