[Laszlo-dev] For Review: Change 20070831-ptw-l Summary: Include instructions on updating Jira when committing

Benjamin Shine ben at laszlosystems.com
Thu Sep 6 13:17:01 PDT 2007


Tucker: you were right. I just spent half an hour tracking down a  
case where my checkin message had referred to the wrong bug number  
*and* I had marked the wrong "fixed in change#" in jira. If I had  
pasted in the log message when I closed the bug, I would have saved  
myself half an hour of rooting around.

On Aug 31, 2007, at 11:45 AM, Benjamin Shine wrote:

>
> I consent to the proposal from the distinguished gentleman from  
> Massachusetts.
>
> On Aug 31, 2007, at 9:47 AM, P T Withington wrote:
>
>> I'm recommending this as 'belt-and-suspenders'.
>>
>> That Jira hook is known to not always work (because it depends on  
>> grepping the svn changes for the bug number, and people are known  
>> to make type-ohs).  By adding this to our process, there is a  
>> backup, which lets us figure out what was really meant.  I know of  
>> two occasions recently where this saved our butts.
>>
>> It's pretty trivial to do, and when you mark the Jira item as  
>> resolved, it wants a comment, and this provides a trivial way to  
>> get a meaningful comment into the system.
>>
>> On 2007-08-31, at 12:24 EDT, Benjamin Shine wrote:
>>
>>>
>>> I'm hesitant to approve this change to our process, because jira  
>>> already does this, and we already have soooo much process. I  
>>> would rather have Yossie go back and turn on the LPP bugs-fixed  
>>> pre-commit trigger, which will ensure that the subversion/jira  
>>> hookup will connect things. The bugs-fixed trigger needs some  
>>> work, but I think the spec that I wrote a few weeks ago for it  
>>> would make it workable.
>>>
>>>
>>> On Aug 31, 2007, at 8:01 AM, P T Withington wrote:
>>>
>>>> Change 20070831-ptw-l by ptw at dueling-banjos.local on 2007-08-31  
>>>> 10:56:38 EDT
>>>>     in /Users/ptw/OpenLaszlo/tools
>>>>     for http://svn.openlaszlo.org/tools
>>>>
>>>> Summary: Include instructions on updating Jira when committing
>>>>
>>>> Technical Reviewer: a.bargull at intensis.de (pending)
>>>> QA Reviewer: ben (pending)
>>>>
>>>> Details:
>>>>     Implement André's suggestion
>>>>
>>>> Files:
>>>> M      trunk/svn/svn-bash.sh
>>>> M      trunk/svn/README.txt
>>>>
>>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070831- 
>>>> ptw-l.tar
>>
>




More information about the Laszlo-dev mailing list