[Laszlo-dev] [Fwd: For Review: Change 20070905-maxcarlson-z Summary: Update replicator with suggestions from a.bargull@intensis.de]

[André Bargull]

I've got just another tiny improvement:
Maybe you should also explicitly destroy "_pointer", because in case you 
destroy the dataset on which you replicate, you'll get a memory leak as 
you'll maintain through "_pointer" a reference to the destroyed dataset 
(this will prevent automatic garbage collection from working...). 
Naturally, you must also clear out manually the "dataset" field on the 
replicator to avoid memory leaks.

In addition to your change, I just saw while checking the 
replicator-class that someone thought it was wise to override the 
"createChildren"-method without calling the super-method. Bad idea -> 
see LPP-3399. This will lead to numerous bugs i.e. a replicator with 
more than one subnode won't ever be actually initialized.

(I just hope that was my last change request, so you can finally commit 
this change... ;-) )

André


Max Carlson wrote:
> Hi,
>
> For some reason, this bounced at your openlaszlo.org address.  Thanks!
>
>
> ------------------------------------------------------------------------
>
> Betreff:
> For Review: Change 20070905-maxcarlson-z Summary: Update replicator 
> with suggestions from a.bargull at intensis.de
> Von:
> Max Carlson <max at openlaszlo.org>
> Datum:
> Wed, 5 Sep 2007 21:09:05 -0700
> An:
> bargull at openlaszlo.org, ptw at laszlosystems.com
>
> An:
> bargull at openlaszlo.org, ptw at laszlosystems.com
> CC:
> laszlo-dev at openlaszlo.org
>
>
> Change 20070905-maxcarlson-z by maxcarlson at plastik on 2007-09-05 
> 21:05:11 PDT
>     in /Users/maxcarlson/openlaszlo/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Update replicator with suggestions from a.bargull at intensis.de
>
> New Features:
>
> Bugs Fixed: LPP-4612 - Explicit replicator doesn't update when items 
> are added or deleted
>
> Technical Reviewer: a.bargull
> QA Reviewer: ptw
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
>
> Tests: test/explicit-replicators/replicator.lzx.
>
> Files:
> M      lps/components/utils/replicator/replicator.lzx
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20070905-maxcarlson-z.tar

-- 
Official OpenLaszlo-Committer ^_^