[Laszlo-dev] For Review: Change 20070905-hqm-6 Summary: fix for return value of onerror event in data loading

[Pablo Kang]

Approved.



On Wed, 5 Sep 2007, Henry Minsky wrote:

> Change 20070905-hqm-6 by hqm at IBM-2E06404CB67 on 2007-09-05 20:33:42 EDT
>    in /cygdrive/c/users/hqm/openlaszlo/wafflecone3/WEB-INF/lps/lfc
>    for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone/WEB-INF/lps/lfc
>
> Summary: fix for return value of onerror event in data loading
>
> New Features:
>
> Bugs Fixed: LPP-4660
>
> Technical Reviewer: pkang (pending)
> QA Reviewer: pbr (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> When the XML SOLO data loader in LzLoadQeueue got no data, it was
> returning the LzLoader as a return value
> in an onerror event. This was confusing, so this changes the return
> value to null.
>
> There was also some broken code which was supposed to set the status
> value of the data request, but
> was referencing class static variables for the constants in a way that
> didn't work, and thus getting
> undefined values. Not sure how this ever worked.
>
>
>
> Tests:
>
> see bug report
> also
> test/lfc/data
> lzpix (SOLO)
> amazon (SOLO)
> http://127.0.0.1:8080/wafflecone3/demos/amazon/amazon.lzx?lzproxied=false
>
>
>
> Files:
> M      kernel/swf/LzLoader.lzs
> M      kernel/swf/LzLoadQueue.as
> M      data/LzHTTPDataProvider.lzs
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070905-hqm-6.tar
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com
>