[Laszlo-dev] For Review: Change 20070903-ptw-a Summary: Add file/line information to backtraces
P T Withington
ptw at pobox.com
Tue Sep 4 19:29:59 PDT 2007
Change 20070903-ptw-a by ptw at dueling-banjos.local on 2007-09-03
18:01:48 EDT
in /Users/ptw/OpenLaszlo/wafflecone-2
for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
Summary: Add file/line information to backtraces
Bugs Fixed:
LPP-4549 'runtime warnings should include file references, line #s'
Technical Reviewer: max, dda at ddanderson.com (pending)
QA Reviewer: ewinard (pending)
Details:
LzMessage: Get file/line information from backtrace if available,
tweak format of locationString.
LzDebug.*: correct padding computation for computeSlotDescription.
LzDebug.js: _dbg_name takes precedence over runtime function name.
LzBacktrace, LzRuntime: Move backtraceStack creation to runtime
so it is
available as early as needed.
LzBacktrace: Add __LzStackFrame.isUserFrame,
.filename, .lineno. Update _dbg_name to display file and line
information. Add LzBacktrace.userStackFrame to get first non-LFC
frame from a backtrace.
Compiler: Correct precedence computations for unparser, ensure
parens are added in all the appropriate places. Needed to handle
expression-lists that backtrace annotation inserts.
JavascriptGenerator, CodeGenerator: Copy location info when
re-writing functions. Note line numbers of call sites for
backtrace. Note file and line on functions for backtraces.
Tests:
smokecheck with backtrace on shows file/line information in debug
messages and in backtraces.
Files:
M WEB-INF/lps/lfc/debugger/LzMessage.lzs
M WEB-INF/lps/lfc/debugger/platform/swf/LzDebug.as
M WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
M WEB-INF/lps/lfc/debugger/LzBacktrace.lzs
M WEB-INF/lps/lfc/compiler/LzRuntime.lzs
M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070903-ptw-
a.tar
More information about the Laszlo-dev
mailing list