[Laszlo-dev] For Review: Change 20070904-maxcarlson-N, Summary: Update explicit replicator when items are added or deleted

André Bargull a.bargull at intensis.de
Tue Sep 4 14:57:19 PDT 2007


I guess I would change this line, because the latter version is in my 
mind more obvious.
this._ondatadel = new LzDelegate(this, '_updateChildren', 
this._pointer.p, 'onDocumentChange')
=> this._ondatadel = new LzDelegate(this, '_updateChildren', 
this.dataset, 'onDocumentChange')

And maybe you should add a manual clean-up for "_ondatadel" to avoid any 
memory leaks.

André


Max Carlson wrote:
> Change 20070904-maxcarlson-N by maxcarlson at plastik on 2007-09-04  
> 13:51:25 PDT
>      in /Users/maxcarlson/openlaszlo/wafflecone
>      for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Update explicit replicator when items are added or deleted
>
> New Features:
>
> Bugs Fixed: LPP-4612 - Explicit replicator doesn't update when items  
> are added or deleted
>
> Technical Reviewer: pkang
> QA Reviewer: ptw
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: test/explicit-replicators/replicator.lzx - Incorporate tests  
> from LPP-4612.
>
> lps/components/utils/replicator/replicator.lzx - Store reference to  
> dataset pointer.  Register _updateChildren() for onDocumentChange  
> events.  Add _updateChildren() method to receive document change  
> events and rerun the xpath.
>
>
> Tests: See LPP-4612.  Also updated test/explicit-replicators/ 
> replicator.lzx.
>
> Files:
> M      test/explicit-replicators/replicator.lzx
> M      lps/components/utils/replicator/replicator.lzx
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070904- 
> maxcarlson-N.tar

-- 
Official OpenLaszlo-Committer ^_^


More information about the Laszlo-dev mailing list