[Laszlo-dev] review: split selectionmanager & dataselectionmangerinto two files

[Philip Romanik]

Approved!

>With the new class syntax, I find it really hard to read with both of
>these classes in the same file.  I also fixed a bug in the
>selectionmanager test case which appears to have been broken since LPS3
>made things case-sensitive.  I *think* I've submitted the review
>correctly, but I'm not exactly sure I did this right.  (I got some
>errors, but the tar file was posted)  If someone is around today and can
>review, that would be nice.  (Complete summary is below)
>
>Sarah
>
>$ svn-review
>test/data/selectionmanager.lzx 
>WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
>WEB-INF/lps/lfc/helpers/Library.lzs
>WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
>tar: 20070903-sallen-6/20070903-sallen-6.tar: file is the archive; not
>dumped
>Can't locate URI/URL.pm in @INC (@INC contains:
>/usr/lib/perl5/5.8/cygwin /usr/lib/perl5/5.8
>/usr/lib/perl5/site_perl/5.8/cygwin /usr/lib/perl5/site_perl/5.8
>/usr/lib/perl5/site_perl/5.8 /usr/lib/perl5/vendor_perl/5.8/cygwin
>/usr/lib/perl5/vendor_perl/5.8 /usr/lib/perl5/vendor_perl/5.8 .) at
>c:\laszlo\svn\tools\trunk/svn/review-mail.pl line 13.
>BEGIN failed--compilation aborted at
>c:\laszlo\svn\tools\trunk/svn/review-mail.pl line 13.
>Changeset:
>http://svn.openlaszlo.org/openlaszlo/patches/20070903-sallen-6.tar
>
>
>Change 20070903-sallen-6 by sallen at sallen-new on 2007-09-03 16:04:47 PDT
>     in /cygdrive/c/laszlo/svn/openlaszlo/branches/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
>Summary: split selectionmanager and dataselectionmanager into two files
>(for readability) and fixed bug in test file
>
>Bugs Fixed: LPP-4638 selectionmanager test broken
>
>Technical Reviewer: (pending)
>QA Reviewer: (pending)
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details:
>
>Tests:
>ran test/data/selectionmanager.lzx
>
>Files:
>M      test/data/selectionmanager.lzx
>A      WEB-INF/lps/lfc/helpers/LzDataSelectionManager.lzs
>M      WEB-INF/lps/lfc/helpers/Library.lzs
>M      WEB-INF/lps/lfc/helpers/LzSelectionManager.lzs
>