[Laszlo-dev] For Review: Change 20070901-Philip-8. Summary: Fix inputtext size

Benjamin Shine ben at laszlosystems.com
Sat Sep 1 09:42:48 PDT 2007


Reviewed, not approved -- from IM: you reuse the variable tch as  
textclip._height and texctip.htmlText. It needs two different  
variables there.

but, ROCK, with the fast fix!

On Sep 1, 2007, at 7:37 AM, Philip Romanik wrote:

> Change 20070901-Philip-8 by Philip at Philip-DC on 2007-09-01 10:29:16  
> EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Fix inputtext size
>
> New Features:
>
> Bugs Fixed: LPP-4626
>
> Technical Reviewer: max
> QA Reviewer: hqm
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> LzTextSprite.getTextfieldHeight reuses the textclip to determine  
> the height. However, it was not resetting the width when it was  
> finished. This change caches/restores a few parameters so that the  
> textclip is restored to its original value.
>
> Some of these changes may not strictly be necessary but it is a  
> safe change.
>
> Tests:
>
> This inputtext should be clickable anywhere along the width:
>   <canvas>
>     <inputtext bgcolor="yellow"/>
>   </canvas>
>
> Also main.lzx runs as expected
>
>
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070901- 
> Philip-8.tar
>
>
>



More information about the Laszlo-dev mailing list