[Laszlo-dev] For Review: Change 20071023-hqm-8 Summary: fix to report errors in media loading

[Max Carlson]

In that case, approved if you'll file a bug against this not working in 
non-proxied mode.  I'm sure there's a way to find out about load 
failures without resorting to MovieClipLoader.

Henry Minsky wrote:
> It only works for proxied media requests.
> 
> To get the SOLO  error handling to work, I'm going to need to use the
> MovieClipLoader.
> 
> I  want to get this in now, so people can use it, and then see if
> replacing loadMovie with the MovieClipLoader API  works; I am just
> concerned about doing all the QA needed for that  though, given the
> numerous bugs we saw getting LzMediaLoader to work with different
> browsers.
> 
> 
> 
> On 10/23/07, Max Carlson <max at openlaszlo.org> wrote:
>> Not approved - the testcase
>> http://localhost:8080/trunk-clean/test/lfc/legals/multiframeresource.lzx?lzproxied=false
>> still shows the issue...  I only see a timeout (after 30 seconds) for
>> the 'should fail' test.
>>
>> Henry Minsky wrote:
>>> Change 20071023-hqm-8 by hqm at IBM-2E06404CB67 on 2007-10-23 12:09:47 EDT
>>>     in /cygdrive/c/users/hqm/openlaszlo/trunk/WEB-INF/lps/lfc
>>>     for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc
>>>
>>> Summary:  fix to report errors in media loading
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-4099
>>>
>>> Technical Reviewer: max
>>> QA Reviewer: pbr
>>> Doc Reviewer:
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details:
>>>
>>> In the case of a server media error, the media loader calls returnData
>>> twice, once from the testLoad loop,  when the image swf is loaded
>>> (normal path), and
>>> then if an error swf was actually returned by the server, it contains swf code
>>> that calls returnData itself.
>>>
>>> That second call was being ignored by returnData because it ignored
>>> any loader which was marked as loaded.
>>>
>>> This fix adds a check for non-null data being returned, and if so, returns
>>> processes it.
>>>
>>>
>>> Tests:
>>>
>>> test/lfc/data/testhttpdata.lzx
>>> test/lfc/data/alldata.lzx
>>>
>>>
>>>
>>> This should report an error immediately in proxied mode
>>>
>>>
>>> <canvas width="100%" height="80%" debug="true">
>>>   <debug  fontsize="12"/>
>>>
>>>   <view resource="http://www.javawen.info/try/news_bg.png"
>>>         onload="Debug.write('onload', this)"
>>>         ontimeout="Debug.write('ontimeout', this)"
>>>         onerror="Debug.write('onerror', this)"
>>> />
>>>
>>> </canvas>
>>>
>>>
>>>
>>> Files:
>>> M      kernel/swf/LzLoader.lzs
>>> M      kernel/swf/LzLoadQueue.as
>>>
>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071023-hqm-8.tar
>>>
>>>
>> --
>> Regards,
>> Max Carlson
>> OpenLaszlo.org
>>
> 
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org