[Laszlo-dev] Fwd: For Review: Change 20071011-hqm-6 Summary: fix dataset timeout event callback

[André Bargull]

Not approved.

LzHTTPLoader.js:
Added try..catch block needs be in "LzHTTPLoader#loadXMLDoc(..)".
Reason: (at least) Firefox sets "XMLHttpRequest#readyState" to 4 when 
you abort a request, but reading "XMLHttpRequest#status" results in an 
exception. So that's what we need to be aware of.

Other changes are fine for me.

Henry Minsky wrote:
> Hi Andre,
>
> This changeset also includes the try..catch you suggested in LPP-4853, maybe you
> could review this as well, since Pablo is a little overloaded right now.
>
>
>
>
> ---------- Forwarded message ----------
> From: Henry Minsky <henry.minsky at gmail.com>
> Date: Oct 11, 2007 10:49 PM
> Subject: For Review: Change 20071011-hqm-6 Summary: fix dataset
> timeout event callback
> To: pkang at laszlosystems.com, ewinard at laszlosystems.com
> Cc: laszlo-dev at openlaszlo.org
>
>
> Change 20071011-hqm-6 by hqm at IBM-2E06404CB67 on 2007-10-11 22:41:08 EDT
>     in /cygdrive/c/users/hqm/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: fix dataset timeout event callback
>
> New Features:
>
> Bugs Fixed: LPP-4881
>
> Technical Reviewer: pkang
> QA Reviewer: ewinard
> Doc Reviewer:
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> The code in LzHttpDataProvider which dispatched on the datarequest
> status type was
> always calling loadResponse, which always set the requests status to
> error if data was null.
>
> Modified the code in LzHttpDataProcider.loadTimeout to just directly
> call the onstatus event
> iinstead of calling loadResponse.
>
> In DHTML, the LzHTTPLoader code to check timeouts needed to use >=
> instead of > for comparison,
> and this was further compounded because if the check for timeout
> failed, another timer was
> never set to check again later.
>
>
> Tests:
>
> Files:
> M      test/data/timeout-dataset.lzx
> M      test/data/sleep.jsp
> M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs
> M      WEB-INF/lps/lfc/kernel/swf/LzHTTPLoader.as
> M      WEB-INF/lps/lfc/kernel/dhtml/LzHTTPLoader.js
> M      WEB-INF/lps/lfc/data/LzHTTPDataProvider.lzs
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071011-hqm-6.tar
>
>
> --
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com
>
>
>