[Laszlo-dev] For Review: Change 20071012-ptw-d Summary: Make backtrace work in <script> on DHTML

[Max Carlson]

Approved!

P T Withington wrote:
> Change 20071012-ptw-d by ptw at dueling-banjos.local on 2007-10-12 18:31:24 
> EDT
>     in /Users/ptw/OpenLaszlo/ringding-clean
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Make backtrace work in <script> on DHTML
> 
> Bugs Fixed:
> LPP-4850: 'Backtrace failing to run under DHTML'
> 
> Technical Reviewer: dda at ddanderson.com (pending)
> QA Reviewer: max (pending)
> 
> Details:
>     Fix JavascriptGenerator to not emit bactrace prefix until _after_
>     var declarations are emitted.
> 
> Tests:
>     <canvas>
>       <script>
>         var bar = "Hello";
>         var foo = LzBrowser.getInitArg('bar');
>         Debug.debug('foo', foo, 'bar', bar);
>       </script>
>     </canvas>
> 
>     yields:
> 
>     DEBUG @lpp-4850.lzx#5: foo Hello bar Hello
> 
>     lzx> Debug.inspect(DEBUG @lpp-4850.lzx#5: foo Hello bar Hello\n)
>     «#LzDebug#1#0| DEBUG @lpp-4850.lzx#5: foo Hello bar Hello\n» {
>     backtrace: lpp-4850.lzx#2/62 <- initialize <- lz.script <- makeChild 
> <- makeSomeVie...
>     file: 'lpp-4850.lzx'
>     line: 5
>     message: 'foo Hello bar Hello\n'
>     }
>     DEBUG @lpp-4850.lzx#5: foo Hello bar Hello\n
>     lzx>
> 
>     Also ran smokecheck in SWF and DHTML.
> 
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071012-ptw-d.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org