[Laszlo-dev] For Review: Change 20070801-jcrowley-1 Summary: add Method removeAllItems at Component baselist

Philip Romanik promanik at laszlosystems.com
Tue Oct 9 07:20:45 PDT 2007


Not approved (I tested on trunk). The change works fine in swf, but 
doesn't remove all the items in dhtml. I had to click on the button 3 
times for all the items to be removed.

This extends the API. Amy says this change needs to go through a 
proposal/review process. Ping Amy directly about it.




>Ah, found one last bug that's still pending review.  Sorry about 
>that... I thought I'd found them all, but there's still this one.
>
>Thanks,
>Josh
>
>Begin forwarded message:
>
>
>From: J Crowley 
><<mailto:jcrowley at laszlosystems.com>jcrowley at laszlosystems.com>
>Date: August 1, 2007 4:51:50 AM EDT
>To: Philip Romanik 
><<mailto:promanik at laszlosystems.com>promanik at laszlosystems.com>, 
>Henry Minsky <<mailto:henry.minsky at gmail.com>henry.minsky at gmail.com>
>Cc: OpenLaszlo development and bug reporting 
><<mailto:laszlo-dev at openlaszlo.org>laszlo-dev at openlaszlo.org>
>Subject: [Laszlo-dev] For Review: Change 20070801-jcrowley-1 
>Summary: add Method removeAllItems at Component baselist
>
>Change 20070801-jcrowley-1 by 
><mailto:jcrowley at doctormanhattan.mshome.net>jcrowley at doctormanhattan.mshome.net 
>on 2007-08-01 04:43:23 EDT
>     in /Users/jcrowley/src/svn/openlaszlo/legals-safe
>     for 
> <http://svn.openlaszlo.org/openlaszlo/branches/legals>http://svn.openlaszlo.org/openlaszlo/branches/legals
>
>Summary: add Method removeAllItems at Component baselist
>
>New Features:
>
>Bugs Fixed: LPP-4054
>
>Technical Reviewer: promanik
>QA Reviewer: henry
>Doc Reviewer:
>
>Documentation:
>
>Release Notes:
>
>Details: Bug fix from community contributor Sebastian Wagner.
>
>No rush on this, by the way; I can wait until after we're
>done with WaffleCone.
>
>Tests: I used this testcase:
>
><canvas width="600" height="400">
>     <list name="testlist" x="10" y="10">
>         <textlistitem text="item 1" value="1" selected="true"/>
>         <textlistitem text="item 2" value="2"/>
>         <textlistitem text="item 3" value="3"/>
>         <textlistitem text="item 4" value="4"/>
>         <textlistitem text="item 5" value="5"/>
>         <textlistitem text="item 6" value="6"/>
>         <textlistitem text="item 7" value="7"/>
>     </list>
>     <button onclick="testlist.removeAllItems()"/>
></canvas>
>
>Clicking the button will remove all the items from the list.
>
>Files:
>M      lps/components/base/baselist.lzx
>
>Changeset: 
><http://svn.openlaszlo.org/openlaszlo/patches/20070801-jcrowley-1.tar>http://svn.openlaszlo.org/openlaszlo/patches/20070801-jcrowley-1.tar
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20071009/abc021e1/attachment-0001.html


More information about the Laszlo-dev mailing list