[Laszlo-dev] For Review: Change 20071114-jcrowley-H Summary: valign and y attribute should have warning

[J Crowley]

Ah, yeah, good point.  I'll change that before checking it in.  Thanks.

On Nov 14, 2007, at 2:45 PM, Philip Romanik wrote:

> Approved.
>
> This is a nit, I think it would be better to take your version,
>
>     if( 'valign' in args && args['valign'] && 'y' in args &&  
> args['y'] && $debug){
>         Debug.warn("y attribute ignored; superseded by valign  
> constraint.");
>     }
>     if( 'align' in args && args['align'] && 'x' in args && args['x']  
> && $debug){
>         Debug.warn("x attribute ignored; superseded by align  
> constraint.");
>     }
>
> and write it this way;
>
> if ($debug) {
>     if( 'valign' in args && args['valign'] && 'y' in args &&  
> args['y']){
>         Debug.warn("y attribute ignored; superseded by valign  
> constraint.");
>     }
>     if( 'align' in args && args['align'] && 'x' in args && args['x']){
>         Debug.warn("x attribute ignored; superseded by align  
> constraint.");
>     }
> }
>
>
>
>> Change 20071114-jcrowley-H by jcrowley at DoctorManhattan.mshome.net on
>> 2007-11-14 13:48:11 EST
>>      in /Users/jcrowley/src/svn/openlaszlo/trunk-g
>>      for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: valign and y attribute should have warning
>>
>> New Features:
>>
>> Bugs Fixed: LPP-2743 - valign and y attribute should have warning
>>
>> Technical Reviewer: max
>> QA Reviewer: pbr
>> Doc Reviewer:
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: Added warnings if x and align or y and
>>       valign are both used on a view, since
>>       align and valign supersede x and y.
>>
>> Tests: Run the following in SWF and DHTML:  Note it
>>       produces a warning if x and align or y and
>>       valign are declared simultaneously.  Does not
>>       warn if either is used individually.
>>
>> <canvas>
>>      <view x="10" align="center"/>
>>      <view y="10" valign="middle"/>
>>      <view x="10"/>
>>      <view y="10"/>
>>      <view align="center"/>
>>      <view valign="middle"/>
>> </canvas>
>>
>> Files:
>> M      WEB-INF/lps/lfc/views/LaszloView.lzs
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071114-jcrowley-H.tar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.openlaszlo.org/pipermail/laszlo-dev/attachments/20071114/60a9629b/attachment.html