[Laszlo-dev] For Review: Change 20071113-ben-p Summary: Un-break media playback by un-declaring LzView.play attribute

[Max Carlson]

Approved.  We really need ot disambiguate play() and play...

Benjamin Shine wrote:
> Change 20071113-ben-p by ben at slim.local on 2007-11-13 11:26:41 PST
>     in /Users/ben/src/svn/openlaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Un-break media playback by un-declaring LzView.play attribute
> 
> Bugs Fixed: (none)
> 
> Technical Reviewer: ptw (pending)
> QA Reviewer: max (pending)
> Doc reviewer: ben (sigh)
> 
> Documentation:
> In the course of the doc tools effort, I added a declaration for the "play"
> attribute to LzView. Unfortunately, there was also a play() method, which
> the play attribute clashed with, revealing that it is not okay to declare
> the play attribute.
> 
> r7226 broke media playback in DHTML:
> Looks like this change broke LaszloView media playback in DHTML. 
> http://localhost:8080/trunk/test/lfc/legals/multiframeresource.lzx?lzr=dhtml&debug=true 
> fails with r7226 applied:
> 
> ERROR 
> @http://localhost:8080/trunk/lps/includes/lfc/LFCdhtml-debug.js#9803: 
> this.play is not a function
> 
> The documentation for LzView.play will not match the 3.4 documentation; 
> it is not yet clear to
> me whether this is an api change or a bug. It will be covered in the 
> coming round of
> tremendous reference qa.
> 
> 
> Tests:
> http://localhost:8080/trunk/test/lfc/legals/multiframeresource.lzx?lzr=dhtml&debug=true 
> 
> runs without errors
> 
> 
> Files:
> M      WEB-INF/lps/lfc/views/LaszloView.lzs
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071113-ben-p.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org