[Laszlo-dev] For Review: Change 20071107-lou-J Summary: change setXXX(foo) to setAtribute('XXX', foo) in the tutorials directory

J Crowley jcrowley at laszlosystems.com
Thu Nov 8 03:33:38 PST 2007


No problem.  Feel free to send any others.  :)

I can file 'em.  There don't seem to be many, but, like, for instance,  
on calculator, there's this line:

"In this section we draw on the concepts presented thus far to create  
a simple — calculator as shown below."

...which has a double-dash in the middle of the sentence.  I'll track  
'em down and let you know.  If you want, I can just fix them and send  
out a changeset for you to review.

On Nov 8, 2007, at 5:32 AM, Lou Iorio wrote:

> Thanks for getting to this so quickly.
>
> Your assumption is correct.
>
> I know about the warning problem (it appears in several places), but  
> not the typos.
>
> If you let me know what they are, I will fix them. You can file the  
> JIRA bug, or I can;
> up to you.
>
> Thanks,
>
> Lou
>
> On Nov 8, 2007, at 6:22 AM, J Crowley wrote:
>
>> Approved.  (I assume there are other bugs that encompass the other  
>> things, like the weird artifact off to the left of the calculator  
>> tutorial, placement of "[Warning]", and a few other typos and  
>> things in the descriptions.  If not, I can file some.  Let me know.)
>>
>> On Nov 7, 2007, at 5:22 PM, Lou Iorio wrote:
>>
>>> Change 20071107-lou-J by lou at loumac.local on 2007-11-07 18:10:43 AST
>>>   in /Users/lou/src/svn/openlaszlo/trunk
>>>   for http://svn.openlaszlo.org/openlaszlo/trunk
>>>
>>> Summary: change setXXX(foo) to setAtribute('XXX', foo) in the  
>>> tutorials directory
>>>
>>> Bugs Fixed: LPP-5041:
>>>
>>> Technical Reviewer: Josh Crowley
>>> QA Reviewer: (pending)
>>> Doc Reviewer: (pending)
>>>
>>> Details: change setXXX(foo) to setAtribute('XXX', foo) in the  
>>> files listed
>>>
>>> did not fix data.dbk, as that file will be rewritten or removed
>>>
>>> Tests: build and visual check.
>>>
>>> Files:
>>> M      docs/src/developers/tutorials/scripting.dbk
>>> M      docs/src/developers/tutorials/text.dbk
>>> M      docs/src/developers/tutorials/art_assets.dbk
>>> M      docs/src/developers/tutorials/calculator.dbk
>>> M      docs/src/developers/tutorials/data_app.dbk
>>> M      docs/src/developers/tutorials/classes.dbk
>>>
>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071107-lou-J.tar
>>
>




More information about the Laszlo-dev mailing list