[Laszlo-dev] For Review: Change 20070725-Philip-8. Summary: Fix dhtml errors after LzModeManager.makeModal()

[J Crowley]

Approved!

On Jul 25, 2007, at 11:32 AM, Philip Romanik wrote:

> Change 20070725-Philip-8 by Philip at Philip-DC on 2007-07-25 11:19:01  
> EST
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/legals
>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>
> Summary: Fix dhtml errors after LzModeManager.makeModal()
>
> New Features:
>
> Bugs Fixed: LPP-4276
>
> Technical Reviewer: jcrowley
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> LzModeManager calls passModeEvent() on a view after makeModal() is  
> called. However, passModeEvent is only defined in certain  
> components (such as window and menu). The fix is to only call  
> passModeEvent() if it exists in the view.
>
>
> Tests:
> Test case in LPP-4276. Click the button and drag the mouse. No  
> errors are seen in dhtml.
>
> <canvas id="maincanvas" width="100%" height="100%" validate="false"  
> debug="false " proxied="false" bgcolor="0x00aaaa">
>     <debug x="650" y="200" width="800" height="400" fontsize="12"/>
>
>     <view id="rv" x="100" y="100" width="200" height="200"  
> bgcolor="red"/>
>
>     <button text="Make Red View Modal"  
> onclick="LzModeManager.makeModal(rv);"/>
> </canvas>
>
>
> Files:
> M      WEB-INF/lps/lfc/services/LzModeManager.lzs
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070725- 
> Philip-8.tar
>
>