[Laszlo-dev] For Review: Change 20070723-ben-y [UPDATED] Summary: Make rich text editor work in Legals

[J Crowley]

Which is preferred syntax, by the way:

typeof var == 'whatever';

or:

typeof(var) == 'whatever';

?

On Jul 24, 2007, at 7:40 AM, P T Withington wrote:

> Not approved yet.
>
> I think here:
>
> -                    if (typeof(global[classname]) == "undefined") {
> +                    if (typeof(classname) == "undefined") {
>
> you should have replaced `global` with `lz`, no?
>
> I've also attached a 'more modern' version of richinputtext.lzx,  
> which replaces the .lzx and .lzl files.  See if you like it:
>
> <richinputtext.lzx>
> On 2007-07-23, at 21:17 EDT, Benjamin Shine wrote:
>
>> [UPDATED **now linkpanel works**]
>>
>> Change 20070723-ben-y by ben at cooper.local on 2007-07-23 15:49:09 PDT
>>     in /Users/ben/src/svn/openlaszlo/branches/legals
>>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>>
>> Summary: Make rich text editor work in Legals
>>
>> New Features:
>>
>> Bugs Fixed:
>> LPP-3431 Ensure richtext and richtexteditor work in OL4/SWF
>> LPP-4347 baserichedittext-test.lzx fails
>> LPP-4348 rich-text: formatfontsize test fails
>> LPP-4349 test-baseedittext.lzx fails
>> LPP-4350 linkdialog-test fails
>> LPP-4351 richtexteditarea-test has warnings and errors in  
>> debugger, but lzunit test passes
>> LPP-4352 scrollrichedittext can't create scrollbar
>> LPP-4356 link dialog does not make links
>>
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: frisco (pending)
>> Doc Reviewer: none
>>
>> Documentation:
>> This changeset makes the rich text editor and all associated  
>> helper classes
>> work in OL4. The changes required to make it work were all just  
>> updating to the new
>> class regime.
>>
>> Release Notes:
>>
>> Details:
>> Also note that none of the rich text api's or components work in  
>> DHTML; this is
>> a swf-only feature.
>>
>> Tests:
>> These tests all compile and run with no errors or warnings:
>>
>> http://localhost:8080/legals/test/extensions/ 
>> test_getText_setText.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/test/extensions/test-lzunit- 
>> richinputtext.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/test/extensions/test-lzunit- 
>> textformat.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/test/extensions/test- 
>> richinputtext.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/test/extensions/test-richinputtext- 
>> default-format.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/test/extensions/test-small- 
>> richinputtext.lzx?debug=true&lzr=swf7
>>
>> http://localhost:8080/legals/lps/components/incubator/test/ 
>> baseedittext-test.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/lps/components/incubator/test/ 
>> scrolledittext-test.lzx?debug=true&lzr=swf7
>>
>> http://localhost:8080/legals/lps/components/incubator/rich-text/ 
>> test/baserichedittext-test.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/lps/components/incubator/rich-text/ 
>> test/richtexteditarea-test.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/lps/components/incubator/rich-text/ 
>> test/richtexteditor-test.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/lps/components/incubator/rich-text/ 
>> test/scrollrichedittext-test.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/lps/components/incubator/rich-text/ 
>> test/linkdialog-test.lzx?debug=true&lzr=swf7
>> http://localhost:8080/legals/lps/components/incubator/rich-text/ 
>> test/linkdialog-driver.lzx?debug=true&lzr=swf7
>>
>> http://localhost:8080/legals/docs/developers/richtext.html Note  
>> that all live examples appear and work.
>>
>> All of these tests also work in lzr=swf8.
>> Files:
>> M      test/extensions/test-richinputtext-default-format.lzx
>> M      lps/components/extensions/views/richinputtext.lzl
>> M      lps/components/incubator/test/baseedittext-test.lzx
>> M      lps/components/incubator/baseedittext.lzx
>> A      lps/components/incubator/rich-text/test/linkdialog-driver.lzx
>> M      lps/components/incubator/rich-text/test/scrollrichedittext- 
>> test.lzx
>> M      lps/components/incubator/rich-text/linkdialog.lzx
>> M      lps/components/incubator/rich-text/scrollrichedittext.lzx
>> M      lps/components/incubator/rich-text/richtexteditarea.lzx
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070723- 
>> ben-y.tar
>>
>>
>> Benjamin Shine
>> Software Engineer, Open Laszlo / Laszlo Systems
>> ben at laszlosystems.com
>>
>>
>>
>