[Laszlo-dev] for review, fix for LPP-3412 switch tag in datasets

[P T Withington]

text?

I guess the real question is what tags have bodies that are XML, not  
LZX?  Is there a way to tell from the schema?  The parser should not  
descend into those.

This might break things because I think that people may write  
<method> inside <text> and get a warning but expect it to work.

On 2007-07-23, at 16:36 EDT, Henry Minsky wrote:

> Hmm, that's a good point. Are there any other special forms the parser
> has, besides include and dataset?
>
>
> On 7/23/07, P T Withington <ptw at openlaszlo.org> wrote:
>> This seems like the upside down way to handle this.  Shouldn't the
>> Parser just have a list of tags it should not descend into when
>> expanding?  E.g., presumably you don't want it to try to process
>> _anything_ inside a dataset tag?  What if someone writes:
>>
>> <dataset>
>>    <foo>
>>      <include ... />
>>    </foo>
>> </dataset>
>>
>> Do you want to be able to have a dataset node named `include`?  I
>> think so.  I think you want to treat the entire body of `dataset` as
>> literal.
>>
>> On 2007-07-23, at 15:26 EDT, Henry Minsky wrote:
>>
>> > Change 20070723-hqm-4 by hqm at IBM-2E06404CB67 on 2007-07-23 15:17:25
>> > EDT
>> >    in /cygdrive/c/users/hqm/openlaszlo/legals4
>> >    for http://svn.openlaszlo.org/openlaszlo/branches/legals
>> >
>> > Summary:  try not to parse out SWITCH tag inside datasets
>> >
>> > New Features:
>> >
>> > Bugs Fixed: LPP-3412
>> >
>> > Technical Reviewer: ptw (pending)
>> > QA Reviewer: (pending)
>> > Doc Reviewer: (pending)
>> >
>> > Documentation:
>> >
>> > Release Notes:
>> >
>> > Details:
>> >
>> > check that a <switch> tag has legal children and is not a
>> > descendant of
>> > a <dataset> before trying to make the parser obey it.
>> >
>> >
>> > Tests:
>> >
>> > testcase from bug report, smokecheck, ant lztest
>> >
>> > Files:
>> > M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java
>> >
>> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070723-
>> > hqm-4.tar
>> >
>> >
>> > --
>> > Henry Minsky
>> > Software Architect
>> > hminsky at laszlosystems.com
>>
>>
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com