[Laszlo-dev] For Review: Change 20070621-ben-x Summary:

[Benjamin Shine]

This was what I intended, but you're right, an opaque background  
would help. I will add.
-ben

On Jul 3, 2007, at 6:47 AM, P T Withington wrote:

> I find the smokecheck very hard to view now.  The progress bar and  
> summary status are overlaid on all sorts of test graphics.  Is this  
> what you intended?  If so, how about adding an opaque background  
> behind the test summary so it is legible?
>
> On 2007-06-28, at 16:12 EDT, Benjamin Shine wrote:
>
>> I am papering over a difference in behavior between the swf and  
>> dhtml runtimes, but checking in this change would make it more  
>> possible to report and debug errors in the dhtml runtime, so  
>> please can I check it in without actually understanding the  
>> problem and why this is the solution?
>>
>> Normally that's poor behavior but criminy, our smokechecks are  
>> failing left and right, and I'd like to know why. This would help.
>>
>> On Jun 22, 2007, at 3:26 AM, P T Withington wrote:
>>
>>> It is not clear to me from your comments whether you are papering  
>>> over a difference in behavior between SWF and DHTML runtimes, or  
>>> you are saying the same broken behavior is observed in both  
>>> runtimes and this is the fix for it.
>>>
>>> If the latter, approved.
>>>
>>> On 2007-06-21, at 18:40 EDT, Benjamin Shine wrote:
>>>
>>>> Change 20070621-ben-x by ben at cooper.local on 2007-06-21 15:34:48  
>>>> PDT
>>>>     in /Users/ben/src/svn/openlaszlo/branches/legals
>>>>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>>>>
>>>> Summary:
>>>>
>>>> New Features:
>>>>
>>>> Bugs Fixed: LPP-4109 DHTML Smokecheck - output is erased, so you  
>>>> can't tell if it succeeded
>>>>
>>>> Technical Reviewer: ptw (pending)
>>>> QA Reviewer: (pending)
>>>> Doc Reviewer: (pending)
>>>>
>>>> Documentation:
>>>> The tests in a TestSuite needn't be laid out with a  
>>>> simplelayout; it is more
>>>> interesting to put them all on top of eachother, so you can see  
>>>> them. More
>>>> importantly, though, taking out the simplelayout allows the  
>>>> focus to jump
>>>> to views in different tests without scrolling the test output  
>>>> off the screen.
>>>> To make sure we can see the test output, we bring the  
>>>> controlPanel to front
>>>> after calling each test.
>>>>
>>>> Release Notes:
>>>>
>>>> Details:
>>>>
>>>>
>>>> Tests:
>>>> smokecheck in dhtml
>>>> ant runlzunit (doesn't pass, but works for the first couple;  
>>>> failure is
>>>>     presumed to be not my fault)
>>>>
>>>> Files:
>>>> M      lps/components/lzunit/lzunit.lzx
>>>>
>>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070621- 
>>>> ben-x.tar
>>>>
>>>>
>>>> Benjamin Shine
>>>> Software Engineer, Open Laszlo / Laszlo Systems
>>>> ben at laszlosystems.com
>>>>
>>>>
>>>>
>>>
>>
>> Benjamin Shine
>> Software Engineer, Open Laszlo / Laszlo Systems
>> ben at laszlosystems.com
>>
>>
>>
>

Benjamin Shine
Software Engineer, Open Laszlo / Laszlo Systems
ben at laszlosystems.com