[Laszlo-dev] [Laszlo-checkins] r5578 - tools/trunk/svn

[P T Withington]

I did not send review mail -- just checked in because I needed it to  
send the Debugger review!

I don't know perl either.  I copied the change from a google answer.  :P

Without this change, I couldn't send the review for the debugger  
change.  With this change, it worked.  QED.

On 2007-07-02, at 13:05 EDT, Benjamin Shine wrote:

> This looks reasonable -- two issues...
> 1) I didn't get a For Review mail -- did you send one?
> 2) I don't really, ahem, *know perl* so I can't really say whether  
> "use Encode qw(encode);" makes any sense.
>
> On Jul 2, 2007, at 6:24 AM, ptw at openlaszlo.org wrote:
>
>> Author: ptw
>> Date: 2007-07-02 06:24:19 -0700 (Mon, 02 Jul 2007)
>> New Revision: 5578
>>
>> Modified:
>>    tools/trunk/svn/review-mail.pl
>> Log:
>> Change 20070702-ptw-I by ptw at dueling-banjos.local on 2007-07-02  
>> 09:22:46 EDT
>>     in /Users/ptw/OpenLaszlo/tools/trunk
>>     for http://svn.openlaszlo.org/tools/trunk
>>
>> Summary: svn tools tweaks
>>
>> Technical Reviewer: ben (pending)
>> QA Reviewer: jgrandy (pending)
>>
>> Details:
>>     encode mail body before escaping
>>
>> Tests:
>>     IWFM
>>
>>
>>
>> Modified: tools/trunk/svn/review-mail.pl
>> ===================================================================
>> --- tools/trunk/svn/review-mail.pl	2007-07-02 13:21:41 UTC (rev 5577)
>> +++ tools/trunk/svn/review-mail.pl	2007-07-02 13:24:19 UTC (rev 5578)
>> @@ -12,6 +12,7 @@
>>
>>  use URI::URL;
>>  use URI::Escape;
>> +use Encode qw(encode);
>>
>>  $to = '';
>>  $cc = 'laszlo-dev at openlaszlo.org';
>> @@ -53,7 +54,7 @@
>>  ";
>>
>>  $url = new URI::URL($url_string);
>> -$url->query($query_string . uri_escape($body));
>> +$url->query($query_string . uri_escape(encode("UTF-8", $body)));
>>
>>  print $url->as_string;
>>
>>
>>
>> _______________________________________________
>> Laszlo-checkins mailing list
>> Laszlo-checkins at openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
>