[Laszlo-dev] For Review: Change 20070702-ptw-D Summary: Preserve Debug.printLength when overriding

P T Withington ptw at pobox.com
Mon Jul 2 10:26:22 PDT 2007


I did that to make it easy to see the diff.  Now that you have  
approved it, I will re-indent and check in.

On 2007-07-02, at 12:56 EDT, Benjamin Shine wrote:

> Approved... Just one little thing: the indentation on the whole try/ 
> catch block down there is off-by-two -- imho it would be nice to  
> indent it to match the new block structure.
>
> -ben
>
> On Jul 2, 2007, at 6:22 AM, P T Withington wrote:
>
>> Change 20070702-ptw-D by ptw at dueling-banjos.local on 2007-07-02  
>> 09:05:57 EDT
>>     in /Users/ptw/OpenLaszlo/legals
>>     for http://svn.openlaszlo.org/openlaszlo/branches/legals
>>
>> Summary: Preserve Debug.printLength when overriding
>>
>> Bugs Fixed:
>> LPP-4234 'DHTML Debug.inspect clobbers printLength'
>>
>> Technical Reviewer: ben (pending)
>> QA Reviewer: frisco (pending)
>>
>> Details:
>>     Guard with a try/catch.  Also, move length computation out of
>>     object test so length will be displayed for strings.
>>
>> Tests:
>>     ant lztest, smokecheck
>>
>>     lzx> Debug.printLength = 24
>>     24
>>     lzx> "A long string that will be abbreviated"
>>     «string(38)| 'A l...»
>>     lzx> Debug.inspect('A long string that will be abbreviated')
>>     'A long string that will be abbreviated'
>>     «string(38)| 'A l...»
>>     lzx> Debug.printLength
>>     24
>>     lzx>
>>
>> Files:
>> M      WEB-INF/lps/lfc/debugger/platform/dhtml/LzDebug.js
>>
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070702- 
>> ptw-D.tar
>
>




More information about the Laszlo-dev mailing list