[Laszlo-dev] [Laszlo-checkins] r3613 - openlaszlo/branches/legals/lps/components/lz

[P T Withington]

Note that svn-commit is driven from the file list in your change.   
When you start a change, it lists all the currently modified files  
below the directory where you are making the change (i.e., it runs  
svn status and puts the output in the change).  If you modify or add  
files subsequently, the do _not_ automatically become part of the  
change.  To add files to a change, you have to run svn status by hand  
and add the missing files to the change.

I'm open to suggestions on how to make this work better, but I did  
not want to automatically add files to a change; because then there  
is no way to exclude files from your change.

I guess we could add another command to update the file list in a  
change.

In the particular case of -r3612, there are no files listed in the  
change at all.  Perhaps there should be a sanity check to not let you  
commit a change with no files.

On 2007-01-30, at 22:10 EST, Jim Grandy wrote:

> I've seen this too; I think there's a bug somewhere in svn-commit.  
> At Ben's suggestion, I've been doing
>
> > cd $LPS_HOME
> > svn commit --file ~/svnchanges/20070130-jgrandyw-z/change.txt
>
> instead. This works as long as you don't want to exclude anything  
> in your tree from the checkin.
>
> jim
>
> On Jan 30, 2007, at 3:45 PM, jcrowley at openlaszlo.org wrote:
>
>> Author: jcrowley
>> Date: 2007-01-30 15:45:22 -0800 (Tue, 30 Jan 2007)
>> New Revision: 3613
>>
>> Modified:
>>    openlaszlo/branches/legals/lps/components/lz/slider.lzx
>> Log:
>> For some reason, this wasn't included with my svn-commit to  
>> revision 3612.
>>
>>
>>
>> Modified: openlaszlo/branches/legals/lps/components/lz/slider.lzx
>> ===================================================================
>> --- openlaszlo/branches/legals/lps/components/lz/slider.lzx	 
>> 2007-01-30 23:40:43 UTC (rev 3612)
>> +++ openlaszlo/branches/legals/lps/components/lz/slider.lzx	 
>> 2007-01-30 23:45:22 UTC (rev 3613)
>> @@ -8,11 +8,11 @@
>>
>>          <state apply="${classroot.showrange}">
>>              <text y="${classroot.track.y + classroot.track.height  
>> + 2}"
>> -                text="${classroot.minvalue}"
>> +                text="${classroot.minvalue}" fgcolor="$ 
>> {classroot.style.textcolor}"
>>              />
>>              <text y="${classroot.track.y + classroot.track.height  
>> + 2}" resize="true"
>>                  x="${classroot.track.x+classroot.track.width-width}"
>> -                text="${classroot.maxvalue}"
>> +                text="${classroot.maxvalue}" fgcolor="$ 
>> {classroot.style.textcolor}"
>>              />
>>          </state>
>>
>>
>>
>> _______________________________________________
>> Laszlo-checkins mailing list
>> Laszlo-checkins at openlaszlo.org
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-checkins
>