[Laszlo-dev] For Review: Change 20070118-ben-c Summary: Make ant clean succeed even if output directories don't exist

[Phillip George Apley]

My approval is moot at this point but you have it anyway.

Interesting that you need the failonerror attribute for a fileset but  
not for a single file or directory.

Any idea what the expression below is about? Delete all files below  
the current directory
that end in tilde, i.e. emacs backup files? Is that really something  
we want to do?
Is the current directory in this case the server directory or the top  
level directory
where ant was called. i.e. "ant clean" could be called from $LPS_HOME  
or $LPS_HOME/WEB-INF/lps/server

     <delete failonerror="false">
       <fileset dir="." defaultexcludes="no" includes="**/*~"/>
     </delete>


On Jan 18, 2007, at 6:41 PM, Benjamin Shine wrote:

> Change 20070118-ben-c by ben at bens-g5.local on 2007-01-18 15:38:10 PST
>     in /Users/ben/src/svn/openlaszlo/branches/legals
>
> Summary: Make ant clean succeed even if output directories don't exist
>
> New Features:
>
> Bugs Fixed:
>
> Technical Reviewer: papley (pending)
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
> "ant clean" should work even if the generated build directories  
> don't exist, so, <delete> tasks
> should succeed even if the thing they're trying to delete doesn't  
> exist. Adding the
> failonerror=false attribute to the delete tasks accomplish this.
>
> Release Notes:
>
> Details:
>
>
> Tests:
> check out a clean tree
> $ ant clean
>
> Files:
> M      WEB-INF/lps/server/build.xml
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070118- 
> ben-c.tar