[Laszlo-dev] For Review: Change 20070108-jgrandyw-a Summary: (Updated^2) Rewrite js2doc comment parser to avoid use of regular

[Jim Grandy]

Yay! Thanks. I finally broken down and built an OpenLaszlo dev  
environment in VMWare, so no more handing you punch cards...

jim

On Jan 8, 2007, at 6:30 PM, Philip Romanik wrote:

> approved (it passed on Windows. See output below)
>
> js2doc.test:
>    [junit] Running org.openlaszlo.js2doc.Comment_Test
>    [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed:  
> 0.031 sec
>    [junit] Testsuite: org.openlaszlo.js2doc.Comment_Test
>    [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed:  
> 0.031 sec
>
>    [junit] Testcase: testCommentScanner took 0.015 sec
>    [junit] Testcase: testjs2docExtractTextContent took 0 sec
>    [junit] Testcase: testjs2docExtractFieldNames took 0.016 sec
>    [junit] Running org.openlaszlo.js2doc.Schema_Test
>    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed:  
> 0.375 sec
>    [junit] Testsuite: org.openlaszlo.js2doc.Schema_Test
>    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed:  
> 0.375 sec
>
>    [junit] Testcase: testSchema took 0.375 sec
>    [junit] Running org.openlaszlo.js2doc.JS2Doc_Test
>    [junit] Jan 8, 2007 9:12:15 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:15 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:15 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:16 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:16 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed:  
> 1.891 sec
>    [junit] Testsuite: org.openlaszlo.js2doc.JS2Doc_Test
>    [junit] Tests run: 7, Failures: 0, Errors: 0, Time elapsed:  
> 1.891 sec
>    [junit] ------------- Standard Error -----------------
>    [junit] Jan 8, 2007 9:12:15 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:15 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:15 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:16 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] Jan 8, 2007 9:12:16 PM
> org.openlaszlo.js2doc.JS2Doc$Visitor visitIfDirective
>    [junit] WARNING: Branch of if statement is not reachable
>    [junit] ------------- ---------------- ---------------
>
>    [junit] Testcase: testComments took 0.766 sec
>    [junit] Testcase: testVariableDeclarations took 0.141 sec
>    [junit] Testcase: testFunctionDefinitions took 0.156 sec
>    [junit] Testcase: testUnhandledDirectives took 0.047 sec
>    [junit] Testcase: testClassDefinitions took 0.328 sec
>    [junit] Testcase: testTopLevelIfDirective took 0.437 sec
>    [junit] Testcase: testClassIfDirective took 0.016 sec
>    [junit] Running org.openlaszlo.js2doc.WholeFile_Test
>    [junit] processing 6 test files
>    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.61  
> sec
>    [junit] Testsuite: org.openlaszlo.js2doc.WholeFile_Test
>    [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.61  
> sec
>    [junit] ------------- Standard Output ---------------
>    [junit] processing 6 test files
>    [junit] ------------- ---------------- ---------------
>
>    [junit] Testcase: testSampleFiles took 1.61 sec
>    [mkdir] Created dir:
> C:\clients\laszlo\svn\src\svn\openlaszlo\branches\legals\WEB-INF\lps 
> \server\build\test
>
>
>
>
> Change 20070108-jgrandyw-a by jgrandyw at jgrandy-pb on 2007-01-08   
> 11:35:39 PST
>    in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals
>
> Summary: (Updated^2) Rewrite js2doc comment parser to avoid use of   
> regular
> expressions against unbounded-length strings. Now we scan a line at a
> time and look for beginning ("/*") and ending ("*/") markers.
>
> New Features:
>
> Bugs Fixed:LPP-3225
>
> Technical Reviewer: pga
> QA Reviewer: pbr
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: Note that the code now uses a Java 1.5 class, Scanner,  
> since  that
> was the simplest way of doing cross-platform line scanning.
>
> Tests:
>
> 'cd WEB-INF/lps/server ; ant js2doc.test'
> 'cd docs/src ; ant lfc.js2doc.generate'
>
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Comment_Test.java
> M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Comment.java
> M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/JS2Doc.java
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070108-  
> jgrandyw-a.tar