[Laszlo-dev] For Review: Change 20070106-jgrandyw-Q Summary: (Updated) Rewrite js2doc comment parser to avoid use of regular

[Jim Grandy]

OK, I'll configure a Windows build system and resubmit after I've  
tested there.

jim

On Jan 6, 2007, at 4:27 PM, Philip Romanik wrote:

> Results for Windows below:
>
> ant js2doc.test
> Buildfile: build.xml
>
> build-opt:
>
> get-svn-info:
>
> setup-build-id:
>      [echo] build.id is 3303 F:\laszlo\svn\src\svn\openlaszlo 
> \branches\legals
>
> init:
>      [echo] sc-parser.uptodate is true
>      [echo] sc-compiler.uptodate is true
>
> lps-xml:
>      [echo] LPS_HOME is F:\laszlo\svn\src\svn\openlaszlo\branches 
> \legals.
>      [copy] Copying 1 file to F:\laszlo\svn\src\svn\openlaszlo 
> \branches\legals\WEB-INF\lps\server\build\org\openlaszlo\server
>
> css-parser:
>
> sc-parser:
>
> sc-compiler:
>
> compile:
>
> js2doc.compile:
>
> manifest:
>      [copy] Copying 1 file to F:\laszlo\svn\src\svn\openlaszlo 
> \branches\legals\WEB-INF\lps\server
>
> copy-i18n-catalogs:
>
> js2doc.rng.dep:
>
> js2doc.rng:
>
> build:
>       [jar] Building jar: F:\laszlo\svn\src\svn\openlaszlo\branches 
> \legals\WEB-INF\lps\server\lib\lps-4.0.x.jar
>
> js2doc.test:
>     [junit] Running org.openlaszlo.js2doc.Comment_Test
>     [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed:  
> 0.031 sec
>     [junit] Testsuite: org.openlaszlo.js2doc.Comment_Test
>     [junit] Tests run: 3, Failures: 0, Errors: 0, Time elapsed:  
> 0.031 sec
>
>     [junit] Testcase: testCommentScanner took 0.015 sec
>     [junit] Testcase: testjs2docExtractTextContent took 0.016 sec
>     [junit] Testcase: testjs2docExtractFieldNames took 0 sec
>     [junit] Running org.openlaszlo.js2doc.Schema_Test
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed:  
> 0.578 sec
>     [junit] Testsuite: org.openlaszlo.js2doc.Schema_Test
>     [junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed:  
> 0.578 sec
>
>     [junit] Testcase: testSchema took 0.578 sec
>     [junit] Running org.openlaszlo.js2doc.JS2Doc_Test
>     [junit] identical: false
>     [junit] test valid: true
>     [junit] expect valid: true
>     [junit] input:  /** this is the subject
>     [junit]  *
>     [junit]  * and here's some more text
>     [junit]  */
>     [junit]  var foo;
>     [junit] output: <?xml version="1.0" encoding="UTF-8"?><js2doc  
> buildoptions="debug profile" runtimeoptions="as2 as3 dhtml jme  
> svg"><variable name="foo"/></js2doc>
>     [junit] expect: <?xml version="1.0" encoding="UTF-8"?><js2doc  
> buildoptions="debug profile" runtimeoptions="as2 as3 dhtml jme  
> svg"><variable name="foo"><doc><text>this is the subject
>
>     [junit]  and here's some more text</text></doc></variable></ 
> js2doc>
>     [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 1 sec
>     [junit] Testsuite: org.openlaszlo.js2doc.JS2Doc_Test
>     [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 1 sec
>     [junit] ------------- Standard Output ---------------
>     [junit] identical: false
>     [junit] test valid: true
>     [junit] expect valid: true
>     [junit] input:  /** this is the subject
>     [junit]  *
>     [junit]  * and here's some more text
>     [junit]  */
>     [junit]  var foo;
>     [junit] output: <?xml version="1.0" encoding="UTF-8"?><js2doc  
> buildoptions="debug profile" runtimeoptions="as2 as3 dhtml jme  
> svg"><variable name="foo"/></js2doc>
>     [junit] expect: <?xml version="1.0" encoding="UTF-8"?><js2doc  
> buildoptions="debug profile" runtimeoptions="as2 as3 dhtml jme  
> svg"><variable name="foo"><doc><text>this is the subject
>
>     [junit]  and here's some more text</text></doc></variable></ 
> js2doc>
>     [junit] ------------- ---------------- ---------------
>
>     [junit] Testcase: testComments took 1 sec
>     [junit]     FAILED
>     [junit] JS2Doc.toXML("/** this is the subject
>     [junit]  *
>     [junit]  * and here's some more text
>     [junit]  */
>     [junit]  var foo;"), org.custommonkey.xmlunit.Diff
>     [junit] [different] Expected presence of child nodes to be  
> 'true' but was 'false' - comparing <variable...> at /js2doc[1]/ 
> variable[1]/@name to <variable...> at /js2doc[1]/variable[1]/@name
>
>     [junit] junit.framework.AssertionFailedError: JS2Doc.toXML("/**  
> this is the subject
>     [junit]  *
>     [junit]  * and here's some more text
>     [junit]  */
>     [junit]  var foo;"), org.custommonkey.xmlunit.Diff
>     [junit] [different] Expected presence of child nodes to be  
> 'true' but was 'false' - comparing <variable...> at /js2doc[1]/ 
> variable[1]/@name to <variable...> at /js2doc[1]/variable[1]/@name
>
>     [junit]     at
> org.custommonkey.xmlunit.XMLAssert.assertXMLIdentical 
> (XMLAssert.java:157)
>     [junit]     at
> org.custommonkey.xmlunit.XMLTestCase.assertXMLIdentical 
> (XMLTestCase.java:221)
>     [junit]     at
> org.openlaszlo.js2doc.JS2Doc_Test.iterateTests(JS2Doc_Test.java:589)
>     [junit]     at
> org.openlaszlo.js2doc.JS2Doc_Test.testComments(JS2Doc_Test.java:100)
>
>
> BUILD FAILED
> F:\laszlo\svn\src\svn\openlaszlo\branches\legals\WEB-INF\lps\server 
> \build.xml:424:
> Test org.openlaszlo.js2doc.JS2Doc_Test failed
>
> Total time: 7 seconds F:\laszlo\svn\src\svn\openlaszlo\branches 
> \legals\WEB-INF\lps\server>
>
>
>
>> Change 20070106-jgrandyw-Q by jgrandyw at jgrandy-pb on 2007-01-06
>> 14:52:27 PST
>>      in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals
>>
>> Summary: (Updated) Rewrite js2doc comment parser to avoid use of  
>> regular expressions against unbounded-length strings. Now we scan  
>> a line at a time and look for beginning ("/*") and ending ("*/")  
>> markers.
>>
>> New Features:
>>
>> Bugs Fixed:LPP-3225
>>
>> Technical Reviewer: pga
>> QA Reviewer: pbr jgrandy
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details:
>>
>> Tests:'cd WEB-INF/lps/server ; ant js2doc.test'
>>
>> Files:
>> M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Comment_Test.java
>> M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Comment.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070106-
>> jgrandyw-Q.tar
>