[Laszlo-dev] For Review: Change 20070105-jgrandyw-M Summary: Rewrite js2doc comment parser to avoid use of regular

[Philip Romanik]

After building, I ran ''ant js2doc.test". The test fails on Windows. My 
java is 1.5.0_06. Here's the output:


ant js2doc.test
Buildfile: build.xml

build-opt:

get-svn-info:

setup-build-id:
      [echo] build.id is 3303 F:\laszlo\svn\src\svn\openlaszlo\branches\legals

init:
      [echo] sc-parser.uptodate is true
      [echo] sc-compiler.uptodate is true

lps-xml:
      [echo] LPS_HOME is F:\laszlo\svn\src\svn\openlaszlo\branches\legals.
      [copy] Copying 1 file to 
F:\laszlo\svn\src\svn\openlaszlo\branches\legals\WEB-INF\lps\server\build\org\openlaszlo\server

css-parser:

sc-parser:

sc-compiler:

compile:

js2doc.compile:

manifest:
      [copy] Copying 1 file to 
F:\laszlo\svn\src\svn\openlaszlo\branches\legals\WEB-INF\lps\server

copy-i18n-catalogs:

js2doc.rng.dep:

js2doc.rng:

build:
       [jar] Building jar: 
F:\laszlo\svn\src\svn\openlaszlo\branches\legals\WEB-INF\lps\server\lib\lps-4.0.x.jar

js2doc.test:
     [junit] Running org.openlaszlo.js2doc.Comment_Test
     [junit] expect: ' c1 \n '
     [junit] normalizedExpect: ' c1 \r\n '
     [junit] actual: ' c1 \r\n\r\n '
     [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.031 sec
     [junit] Testsuite: org.openlaszlo.js2doc.Comment_Test
     [junit] Tests run: 1, Failures: 1, Errors: 0, Time elapsed: 0.031 sec
     [junit] ------------- Standard Output ---------------
     [junit] expect: ' c1 \n '
     [junit] normalizedExpect: ' c1 \r\n '
     [junit] actual: ' c1 \r\n\r\n '
     [junit] ------------- ---------------- ---------------

     [junit] Testcase: testCommentScanner took 0.016 sec
     [junit]     FAILED
     [junit] /* c1
     [junit]  */ expected:<......> but was:<...
     [junit] ...>
     [junit] junit.framework.ComparisonFailure: /* c1
     [junit]  */ expected:<......> but was:<...
     [junit] ...>
     [junit]     at
org.openlaszlo.js2doc.Comment_Test.testCommentScanner(Comment_Test.java:80)


BUILD FAILED
F:\laszlo\svn\src\svn\openlaszlo\branches\legals\WEB-INF\lps\server\build.xml:424:
Test org.openlaszlo.js2doc.Comment_Test failed

Total time: 4 seconds



>Change 20070105-jgrandyw-M by jgrandyw at jgrandy-pb on 2007-01-05
>20:51:20 PST
>      in /Users/jgrandyw/dev/svn/openlaszlo/branches/legals
>
>Summary: Rewrite js2doc comment parser to avoid use of regular expressions 
>against unbounded-length strings. Now we scan a line at a time and look 
>for beginning ("/*") and ending ("*/") markers.
>
>New Features:
>
>Bugs Fixed:LPP-3225
>
>Technical Reviewer: pga
>QA Reviewer: pbr jgrandy
>Doc Reviewer: (pending)
>
>Documentation:
>
>Release Notes:
>
>Details:This began failing again on linux-builder, so I took the hint
>and rewrote the routine. I'll test on linux-builder. Phill A, can you
>code-review, and Phil R, can you test on Windows?
>
>
>Tests: cd WEB-INF/lps/server ; ant js2doc.test
>
>Files:
>M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Comment_Test.java
>M      WEB-INF/lps/server/src/org/openlaszlo/js2doc/Comment.java
>
>Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070105-
>jgrandyw-M.tar