[Laszlo-dev] For Review: Change 20071219-dda-U Summary: Better treatment of error messages

[Donald Anderson]

Change 20071219-dda-U by dda at Lester.local on 2007-12-19 15:30:44 EST
     in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
     for http://svn.openlaszlo.org/openlaszlo/branches/devildog

Summary: Better treatment of error messages

New Features:

Bugs Fixed: LPP-5234

Technical Reviewer: ptw (pending)
QA Reviewer: hminsky (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
     The errors from the third party compiler have file/line numbers  
that may
     not make sense to the end user (since we create lots of files to  
compile
     behind their back), so there is a translation of these line  
numbers back
     to the lines from the original source files.  However, when  
compiling
     LFC or other system software, we would like access to the error  
file/lines
     actually produced, since we do have access to the temp files for  
debugging.

     Three changes made related to this:
     - when the error line produced was '0' before, now always show the
       'actual' file/linenumbers.
     - even if there is a valid source line number, always show the
       'actual' file/linenumber in brackets [].  When we hook
       this up in the browser environment, we may choose to elide this.
     - some minor refactoring in the source to get greater sharing.

Tests:
    Verified that errors now produced have information that line
    up with tmp files used in compilation.

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/TranslationUnit.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071219-dda-U.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

voice: 617-547-7881
email: dda at ddanderson.com
www: http://www.ddanderson.com