[Laszlo-dev] For Reivew: Change 20071218-Philip-6. Summary: Fixed text size caching in IE7

Philip Romanik promanik at laszlosystems.com
Tue Dec 18 13:40:25 PST 2007


Change 20071218-Philip-6 by Philip at Philip-DC on 2007-12-18 16:27:25 EST
     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/trunk
     for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: Fixed text size caching in IE7

New Features:

Bugs Fixed: LPP-5176

Technical Reviewer: max
QA Reviewer: (pending)
Doc Reviewer: (pending)

Documentation:

Release Notes:

Details:
LzTextSprite.getTextSize() has a cache to save computation, and this 
cache is erased every 1000 entries. The problem is the counter is 
also zeroed. In IE, the tag name includes the counter value and the 
name cannot be reused without generating javascript errors. I think 
IE is trying to reuse the name, but the object has been deleted.

The fix is to never zero the counter. The cache is erased but the 
counter value is set to its old value.


Tests:
Run test in LPP-5176 in IE7/dhtml. Also tested in FF/dhtml.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071218-Philip-6.tar



More information about the Laszlo-dev mailing list