[Laszlo-dev] For Review: Change 20071213-dda-K Summary: SWF9: Fixes related to propogating through new AS3 keywords and getting buildlfc working further.

[Donald Anderson]

Change 20071213-dda-K by dda at freddie.local on 2007-12-13 16:46:48 EST
     in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
     for http://svn.openlaszlo.org/openlaszlo/branches/devildog

Summary:  SWF9: Fixes related to propogating through new AS3 keywords  
and getting buildlfc working further.

New Features: none

Bugs Fixed:  LPP-5434, LPP-5178

Technical Reviewer: ptw (pending)
QA Reviewer: hminsky (pending)
Doc Reviewer: (pending)

Documentation:  none

Release Notes: none

Details:
     Emit static, etc. keywords that appear before methods, vars,  
classes.
     Even though prelim work was done to parse these previously,  
needed to fix up a
     few things:

   + when walking through the AST, the 'ModifiedDefinition' node was  
elided from the tree.
     Now, if we are parsing for SWF9, these nodes are kept in the tree.

   + added a visitModifiedDefinition in ParseTreePrinter that is  
modified in SWF9ParseTreePrinter

   + fixed some simple setters on ASTModifiedDefinition class.

    Now when we emit the 'static' keyword in front of the 'function'  
definition,
    the presence of the /* -*- file .... */ comment between these two  
- putting
    'static' and 'function' on two separate lines, triggered an  
apparent bug
    in the third party compiler.  Some extra work was needed to get  
'static' and
    'function' next to each other on the same line.  (This will also  
be handled
    correctly for 'class' if we decide to emit the file comment there.)

Tests:
    just buildlfc

Files:
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/ 
SWF9ParseTreePrinter.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/parser/ 
ASTModifiedDefinition.java

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071213-dda- 
K.tar



--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  dda at ddanderson.com
WWW:    http://www.ddanderson.com