[Laszlo-dev] For Review: Change 20071212-dda-X Summary: SWF9: More fixes for LzNode

[Donald Anderson]

I agree with that.  Perhaps after the merge back into trunk...?

On Dec 12, 2007, at 6:27 PM, P T Withington wrote:

> It looks to me like what you really want to do is break out the  
> protocol for translateClassDirectiveBlock to dispatch on the  
> permitted AST's and call overrideable translators for var,  
> function, statement, etc.  What you did is fine for now, but a more  
> oop-y modularity would be nice.
>
> On 2007-12-12, at 18:12 EST, Donald Anderson wrote:
>
>> Change 20071212-dda-X by dda at freddie.local on 2007-12-12 18:05:00 EST
>>    in /Users/dda/laszlo/src/svn/openlaszlo/branches/devildog
>>    for http://svn.openlaszlo.org/openlaszlo/branches/devildog
>>
>> Summary: SWF9: More fixes for LzNode
>>
>> New Features: none
>>
>> Bugs Fixed: LPP-5234 (not completely fixed)
>>
>> Technical Reviewer: ptw (pending)
>> QA Reviewer: hminsky (pending)
>> Doc Reviewer: (pending)
>>
>> Documentation: none
>>
>> Release Notes: none
>>
>> Details:
>>    More fixes for LzNode:
>>
>> +  A previous commit added in a call to  
>> translateClassDirectivesBlocks,
>>    but that function moves vars/methods from a class block into  
>> properties.
>>    For SWF9, we want these functions to be real methods on the class,
>>    so there is a new compiler (internal) option, called  
>> KEEP_CLASS_METHODS
>>    that indicates that vars/methods should be kept as regular  
>> declared
>>    elements of the class.
>>
>> +  Fixed a method declaration the placement of setting the  
>> inDefaultClass which
>>    were causing the generator to not accurately know if it was in  
>> a function
>>    or a class.
>>
>> Tests:
>>  buildlfc with only LzNode enabled.
>>
>> Files:
>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/CommonGenerator.java
>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
>> M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071212- 
>> dda-X.tar
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> Voice:  617-547-7881
>> Email:  dda at ddanderson.com
>> WWW:    http://www.ddanderson.com
>>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  dda at ddanderson.com
WWW:    http://www.ddanderson.com