[Laszlo-dev] For Review: Change 20071210-dda-l Summary: Allow certain new keywords to be identifiers

[Donald Anderson]

It's running now, so far so good.
I don't expect a new error since the grammar should
be slightly more permissive now.

- Don

On Dec 10, 2007, at 6:24 PM, Benjamin Shine wrote:

>
> After making this change, does "ant doc" still work?
>
>
> On Dec 10, 2007, at 1:30 PM, Donald Anderson wrote:
>
>> Change 20071210-dda-l by dda at freddie.local on 2007-12-10 16:16:47 EST
>>     in /Users/dda/laszlo/src/svn/openlaszlo/trunk
>>     for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Allow certain new keywords to be identifiers
>>
>> New Features: none
>>
>> Bugs Fixed: LPP-5226, LPP-5178
>>
>> Technical Reviewer: ptw
>> QA Reviewer: hminsky
>> Doc Reviewer: (pending)
>>
>> Documentation: none
>>
>> Release Notes: none
>>
>> Details:
>>    New keywords: internal, final, override, dynamic, static can be  
>> identifiers.
>>    Confirmed with SWF9 third party compiler that these are  
>> allowed, and also that
>>    public/private/protected are not allowed (oddly enough).
>>
>>    Made a common shared function in the grammar to get maximal  
>> code sharing.
>>
>>    This change fixes a problem exposed by the addition of the new  
>> keywords.
>>    We need the keywords to make changes to LFC files that will be  
>> shared
>>    among runtimes.
>>
>> Tests:
>>   http://localhost:8080/trunk/examples/components/style_example.lzx
>>      with SWF7 (the reported test case), also SWF8 and DHTML.
>>   smokecheck SWF8, DHTML
>>   Tried some .lzs files mentioned in LPP-5178 to verify that the
>>      new keywords are still accepted in the appropriate places.
>>
>> Files:
>> M      WEB-INF/lps/server/sc/src/org/openlaszlo/sc/Parser.jjt
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20071210- 
>> dda-l.tar
>>
>>
>>
>> --
>>
>> Don Anderson
>> Java/C/C++, Berkeley DB, systems consultant
>>
>> Voice:  617-547-7881
>> Email:  dda at ddanderson.com
>> WWW:    http://www.ddanderson.com
>>
>


--

Don Anderson
Java/C/C++, Berkeley DB, systems consultant

Voice:  617-547-7881
Email:  dda at ddanderson.com
WWW:    http://www.ddanderson.com