[Laszlo-dev] [UPDATE] For Review: Change 20070821-ptw-l Summary: Inline setAttribute

P T Withington ptw at pobox.com
Mon Aug 27 13:10:23 PDT 2007


[UPDATE: Only inline setAttribute when called as lzsc (i.e., when  
compiling scripts such as LFC and lps/includes).

Change 20070821-ptw-l by ptw at dueling-banjos.local on 2007-08-21  
06:55:15 EDT
     in /Users/ptw/OpenLaszlo/wafflecone
     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone

Summary: Inline setAttribute

Bugs Fixed:
LPP-4513 'Compiler Improvements to address performance'

Technical Reviewer: ptw, max
QA Reviewer: henry
Doc Reviewer: (pending)

Details:
     CodeGenerator.java, JavascriptGenerator.java - Inline calls to
     setAttribute() when called as the script compiler, unless #pragma
     "passThrough=true".

     LzContextMenu.js, LzTextSprite.js, LzInputTextSprite.js,
     drawview.lzx, embednew.js, iframemanager.js - Add #pragma
     "passThrough=true" to prevent div.setAttribute() from being
     inlined.

Tests:
     All demos run as before (but faster in swf and dhtml).  smokecheck
     also runs and passes now.

Files:
M      WEB-INF/lps/lfc/kernel/dhtml/LzContextMenu.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
M      WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js
M      WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java
M      WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java
M      lps/includes/source/embednew.js
M      lps/includes/source/iframemanager.js

Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070821-ptw- 
l.tar


More information about the Laszlo-dev mailing list