[Laszlo-dev] for review, LPP-1417, add backtrace flag to runtime

[P T Withington]

Three comments:

1) Should ?lzbacktrace=true imply ?debug=true?

2) In lzc, I have tried to match gcc with the short options.  In  
which case I think the short option for --debug should be -g1 and the  
short option -g and -g2 should be the same as --debug and -- 
backtrace.  (In either case, you should update the help string.)

3) Should we remove compiler.debug.backtrace from lps.properties now  
(and support for it)?  It seems superfluous.

Approved!

On 2007-08-17, at 03:15 EDT, Henry Minsky wrote:

> Change 20070817-hqm-8 by hqm at IBM-2E06404CB67 on 2007-08-17 03:06:14  
> EDT
>     in /cygdrive/c/users/hqm/openlaszlo/wafflecone2
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: add lzbacktrace query arg to turn on backtraces
>
> New Features:
>
> Bugs Fixed: LPP-1417
> Bug: LPP-1417
>
> Technical Reviewer: ptw (pending)
> QA Reviewer: max (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
>
> Release Notes:
>
> backtrace is enabled via new button on dev console, or by
> lzbacktrace=true query arg, or new --backtrace arg to lzc
>
>
> Details:
>
> + support new backtrace flag
>
> Added new checkbox on dev console to enable backtrace
>
> Tests:
>
> test app prints Debug.warn('foo'), click on it to see if backtraces  
> are
> turned on
>
> see JIRA for test case
>
>
>
> Files:
> M      WEB-INF/lps/schema/lzx.rnc
> M      WEB-INF/lps/server/src/org/openlaszlo/cm/ 
> CompilationManager.java
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/server/LPS.java
> M
> WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ 
> ResponderCompile.java
> M
> WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ 
> ResponderLFC.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> CanvasCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> ToplevelCompiler.java
> M
> WEB-INF/lps/server/src/org/openlaszlo/compiler/ 
> CompilationEnvironment.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Main.java
> M      lps/includes/source/embednew.js
> M      lps/admin/dev-console.lzx.js
> M      lps/admin/dev-console.lzx.swf
> M      lps/admin/dev-console.lzx
>
>
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070817- 
> hqm-8.tar
>
>
> -- 
> Henry Minsky
> Software Architect
> hminsky at laszlosystems.com