[Laszlo-dev] For Review: Change 20070808-ben-z Summary: Cleanup of insertion point movement in rich text editor

[Max Carlson]

This looks great overall!  Comments below:

Benjamin Shine wrote:
> Change 20070808-ben-z by ben at slim.local on 2007-08-08 17:24:47 PDT
>     in /Users/ben/src/svn/openlaszlo/branches/wafflecone
>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
> 
> Summary: Cleanup of insertion point movement in rich text editor
> 
> New Features:
> 
> Bugs Fixed: LPP-4396 rich text editor: clicking bold moves insertion point
> 
> Technical Reviewer: max (pending)
> QA Reviewer: mamye (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Using the fix for LPP-4015 (Text selection position and size should be 
> available during onblur event) I sanitized the rich text editor's saving 
> and restoring of the selected region.
> 
> There is a new bug introduced with this checkin: LPP-4461: In rich text 
> editor, font color combo box does not update when cursor moves to 
> different colored text. I am tracking this down.
> 
> Release Notes:
> 
> Details:
> 
> richtexteditarea.lzx -- The big change here was in the onblur method. 
> Now that LPP-4015 has been fixed, we can store the correct selection 
> range whenever we're about to lose focus. I also undid a change 
> suggested by an external contributor, because it was causing problems in 
> the new world, perhaps because it was incompatible with the 
> platform/wafflecone rich text editor.
> 
> linkdialog-test.lzx  -- very explicitly created connections between the 
> link dialog and the editor.
> 
> formatfontcolor.lzx -- moved dataset describing color choices out of a 
> state. This will slow startup a little bit, but the whole thing doesn't 
> work if the color choices are in a state.

Do we have a bug to track the this issue?  I feel like we should drill 
down and figure out why states inside datasets are failing rather than 
working around it.

> Tests:
> Interactive test available here:
> http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-test.lzx?debug=true&lzr=swf8 
> 
> 
> lzunit tests here:
> http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/linkdialog-test.lzx?debug=true&lzr=swf8 
> 
> http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/scrollrichedittext-test.lzx?debug=true&lzr=swf8 
> 
> http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/richtexteditor-test.lzx?lzr=swf8&debug=true 

This shows 0 tests running.

> http://localhost:8080/wafflecone/lps/components/incubator/rich-text/test/richtexteditarea-test.lzx?debug=true&lzr=swf8 

All the other unit tests pass...

> 
> Files:
> 
> M      lps/components/incubator/rich-text/formatfontcolor.lzx
> M      lps/components/incubator/rich-text/richtexteditarea.lzx
> M      lps/components/incubator/rich-text/test/linkdialog-test.lzx
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070808-ben-z.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org