[Laszlo-dev] For Review: Change 20070806-maxcarlson-l Summary: Only set style constraints if the existing value is null

Max Carlson max at openlaszlo.org
Tue Aug 7 16:46:24 PDT 2007


I just updated the unit tests to check for this.

P T Withington wrote:
> Phil,
> 
> Could you test or verify that the converse works correctly?  That is, 
> that if I have a superclass attribute with a simple value that a 
> subclass and instance can override that simple value with a style 
> constraint?
> 
> ---
> Le iPhone, c'est moi.
> 
> On Aug 7, 2007, at 9:43 AM, Philip Romanik <promanik at laszlosystems.com> 
> wrote:
> 
>> Approved (sorry for the delay).
>>
>>> Change 20070806-maxcarlson-l by maxcarlson at plastik on 2007-08-06
>>> 18:53:14 PDT
>>>     in /Users/maxcarlson/openlaszlo/wafflecone
>>>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>>>
>>> Summary: Only set style constraints if the existing value is null
>>>
>>> New Features:
>>>
>>> Bugs Fixed: LPP-2894 - CSS: subclasses and instances can't override
>>> style constraints set on superclass*
>>>
>>> Technical Reviewer: promanik
>>> QA Reviewer: ben, ptw
>>> Doc Reviewer: (pending)
>>>
>>> Documentation:
>>>
>>> Release Notes:
>>>
>>> Details: LzNode.lzs - Only set styleConstraints[k] if this[k] is null.
>>>
>>>
>>> Tests: http://localhost:8080/wafflecone/test/style/constraints/
>>> main.lzx?lzr=swf8 now passes.
>>>
>>> Files:
>>> M      WEB-INF/lps/lfc/core/LzNode.lzs
>>>
>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070806-
>>> maxcarlson-l.tar
>>
>>

-- 
Regards,
Max Carlson
OpenLaszlo.org


More information about the Laszlo-dev mailing list