[Laszlo-dev] For Review: Change 20070806-maxcarlson-x Summary: Remove setter for LzNode.data

[Pablo Kang]

Looks good. Adding a comment why setData isn't a setter for the data attribute 
would help. Alternatively, rename setData to something else and comment what 
that method does exactly. In particular, how it creates a datapath if one 
doesn't already exist.

pablo

On Mon, 6 Aug 2007, Max Carlson wrote:

> Change 20070806-maxcarlson-x by maxcarlson at plastik on 2007-08-06 14:30:15 PDT
>   in /Users/maxcarlson/openlaszlo/wafflecone
>   for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>
> Summary: Remove setter for LzNode.data
>
> New Features:
>
> Bugs Fixed: LPP-4405 'Implement ExplicitReplication' (partial)
>
> Technical Reviewer: promanik
> QA Reviewer: ptw, pkang
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details: LzNode.lzs - Remove setter for .data -> setData().
>
> replicator.lzx - Call v.setData( this.nodes[ n ] ); instead of 
> setAttribute('data', ...)
>
>
> Tests: silver/main.lzx?lzr=swf8 runs again, 
> http://localhost:8080/wafflecone/test/explicit-replicators/replicator.lzx?lzr=swf8 
> passes
>
> Files:
> M      WEB-INF/lps/lfc/core/LzNode.lzs
> M      lps/components/utils/replicator/replicator.lzx
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20070806-maxcarlson-x.tar