[Laszlo-dev] For Review: Change 20070803-hqm-0 Summary: preliminary implementation of dataprovider API

[Henry Minsky]

On 8/5/07, P T Withington <ptw at openlaszlo.org> wrote:
> Questions:
>
> 1. Should there be an abstract `dataprovider` class?
>

There was the doRequest method on the DataProvider interface, so I didn't think
it was worth making a base class for it.


> 2. If we had a dataprovider class, we could avoid global pollution by
> having defaultdataprovider be a property of that.

I'll try some things with Pablo, and see what seems to be the most expedient
and easy to deal with when he's implmenting the webtop dataprovider
class, and then
we'll make a proposal for what we find works out most smoothly.



>
> 3. I don't recall `abortLoadForRequest` being part of the
> dataprovider API, did I miss that?

We didn't put that in the  API, but LzDataset supports an abort()
method, which LzHTTPDataSource supported, so I need to support that
somehow. The implementation in LzHTTPDataProvider is not working yet,
but I guess we should see if we want to add it to the abstract
DataProvider API.


>
>
> On 2007-08-03, at 17:08 EDT, Henry Minsky wrote:
>
> > This is a first cut at an implementation of the datarequest/
> > dataprovider API
> > that implements lzhttpdataprovider, and modifies lzdataset to use
> > this api.
> >
> >
> >
> >
> > Change 20070803-hqm-0 by hqm at IBM-2E06404CB67 on 2007-08-03 16:57:12
> > EDT
> >     in /cygdrive/c/users/hqm/openlaszlo/wafflecone/WEB-INF/lps/lfc
> >     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone/
> > WEB-INF/lps/lfc
> >
> > Summary: preliminary implementation of dataprovider API
> >
> > New Features:
> >
> > Bugs Fixed: LPP-4404
> >
> > Technical Reviewer: pkang, ptw (pending)
> > QA Reviewer: (pending)
> > Doc Reviewer: (pending)
> >
> > Documentation:
> >
> > Release Notes:
> >
> > Details:
> >
> > implements lzhttpdataprovider, lzhttpdatarequest, modifies lzdataset
> > to use the new API
> >
> > Tests:
> >
> > test/lfc/data/alldata.lzx
> >
> > [tests which refer to proxied response headers are failing currently]
> >
> >
> > Files:
> > M      kernel/swf/LzLoadQueue.as
> > M      kernel/swf/LzHTTPLoader.as
> > M      kernel/dhtml/LzHTTPLoader.js
> > A      data/LzDataRequest.lzs
> > M      data/LzDataElement.lzs
> > A      data/LzHTTPDataProvider.lzs
> > M      data/LzDataset.lzs
> > M      data/Library.lzs
> >
> > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070803-
> > hqm-0.tar
> >
> >
> > --
> > Henry Minsky
> > Software Architect
> > hminsky at laszlosystems.com
>
>


-- 
Henry Minsky
Software Architect
hminsky at laszlosystems.com