[Laszlo-dev] For Review: Summary: More LFC optimization/simplification

[Benjamin Shine]

These are known, and they're on my list, except for this one:
> TestFailure: ConstraintSpeedTestCase >>> testLookupTimes failed:  
> True:  expected true got false

This means that my test for lookup times for CSS is dissatisfied with  
how long it took to look up some css values -- it's going TOO FAST now!

I'll adjust the test file to allow for these new faster lookups, then  
check in the change.

-ben

On Aug 3, 2007, at 4:37 PM, Philip Romanik wrote:

> Approved.
>
> One comment. When I run metasuite.lzx I get 4 errors:
>
> Tests: 531 Failures: 4 Errors: 0
> TestFailure: SimpleTestCase >>> testBasics failed: Equals:   
> expected 50 got 279
> TestFailure: ConstraintSpeedTestCase >>> testLookupTimes failed:  
> True:  expected true got false
> TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint
> failed: Equals:  expected 32768 got 8388736
> TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint
> failed: Equals:  expected 17337 got 8388736
>
>
>
>> ehange 20070803-maxcarlson-n by maxcarlson at Plastik.local on
>> 2007-08-03 15:22:00 PDT
>>      in /Users/maxcarlson/openlaszlo/wafflecone
>>      for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>>
>> Summary: More LFC optimization/simplification
>>
>> New Features:
>>
>> Bugs Fixed: LPP-4414 - Improve startup performance
>>
>> Technical Reviewer: ben
>> QA Reviewer: promanik
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: lztest-textheight.lzx - label multiline inputtext test  
>> better.
>>
>> LzCSSStyle.js - Remove recursion, correct getPropertyValueFor()
>> warnings, simplify _selectorApplies().
>>
>> LzNode.lzs - Clean up getUID().
>>
>>
>> Tests: http://localhost:8080/wafflecone/test/style/metasuite.lzx?
>> lzr=swf8&debug=true passes (with new warnings!) and silver/main.lzx?
>> lzr=dhtml&lzt=html is slightly faster (with the same number of method
>> calls)
>>
>> Files:
>> M      test/lztest/lztest-textheight.lzx
>> M      WEB-INF/lps/lfc/services/LzCSSStyle.js
>> M      WEB-INF/lps/lfc/core/LzNode.lzs
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070803-
>> maxcarlson-n.tar
>
>