[Laszlo-dev] For Review: Summary: More optimization of LFC

Max Carlson max at openlaszlo.org
Thu Aug 2 10:16:24 PDT 2007


Yeah, I tried doing that and it doesn't work.  Not sure why.  In fact, I 
tried that back before Tucker suggested it, now that I think about it...

Philip Romanik wrote:
> Approved!
> 
> You might want to tweak your change in LaszloEvents like Tucker suggested:
> 
>     if (d.c[d.f]) d.c[d.f]( sd );
> 
> to:
> 
>     var f = d.c[d.f];
>     if (f) f( sd );
> 
> 
> 
> 
>>   20070801-maxcarlson-V by maxcarlson at plastik on 2007-08-01 20:51:00 PDT
>>      in /Users/maxcarlson/openlaszlo/wafflecone
>>      for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>>
>> Summary: More optimization of LFC
>>
>> New Features:
>>
>> Bugs Fixed: LPP-4414 - Improve startup performance (partial)
>>
>> Technical Reviewer: promanik
>> QA Reviewer: ben
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: LzCSSStyle.js - Cache getPropertyValueFor() calls.  Only
>> call _selectorApplies() for compound css statements.
>>
>> LzNode.lzs - Only call constructWithArgs() if it exists.
>>
>> LaszloEvents.lzs - Check for null reference.
>>
>>
>> Tests: ...silver/main.lzx?lzr=dhtml&lzt=html shows ~24029 fewer total
>> calls (252524 total before, 228495 now).  http://localhost:8080/
>> wafflecone/test/style/constraints/main.lzx?lzr=swf8 passes as before,
>> shows 405ms for lookup test.
>>
>> Files:
>> M      WEB-INF/lps/lfc/services/LzCSSStyle.js
>> M      WEB-INF/lps/lfc/core/LzNode.lzs
>> M      WEB-INF/lps/lfc/events/LaszloEvents.lzs
>>
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20070801-
>> maxcarlson-V.tar
> 
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org


More information about the Laszlo-dev mailing list