[Laszlo-dev] For Review: Change 20070801-maxcarlson-k Summary: Inline LzCSSStyle._selectorApplies() testing and first level of recursion

[Max Carlson]

Good to know.  FWIW, I see the same errors with my change, but in 
reverse order:

ERROR: Equals:  expected 17337 got 8388736
ERROR: Equals:  expected 32768 got 8388736

Benjamin Shine wrote:
> FYI, a good test of all the CSS stuff is in
> http://localhost:8080/wafflecone/test/style/constraints/main.lzx
> 
> There are currently two known failures:
> TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint 
> failed: Equals:  expected 32768 got 8388736
> TestFailure: CSSSubclassingTestCase >>> testSubclassOverrideConstraint 
> failed: Equals:  expected 17337 got 8388736
> ...which are my bug, LPP-4407.
> 
> Please run this test when tweaking CSS. (I'm running it now, with your 
> change applied...)
> 
> 
> 
> 
> On Aug 1, 2007, at 12:30 PM, Max Carlson wrote:
> 
>> Change 20070801-maxcarlson-k by maxcarlson at plastik on 2007-08-01 
>> 12:24:00 PDT
>>     in /Users/maxcarlson/openlaszlo/wafflecone
>>     for http://svn.openlaszlo.org/openlaszlo/branches/wafflecone
>>
>> Summary: Inline LzCSSStyle._selectorApplies() testing and first level 
>> of recursion
>>
>> New Features:
>>
>> Bugs Fixed: LPP-4414 - Improve startup performance (partial)
>>
>> Technical Reviewer: promanik
>> QA Reviewer: ben
>> Doc Reviewer: (pending)
>>
>> Documentation:
>>
>> Release Notes:
>>
>> Details: Do early tests to short-circuit calls to _selectorApplies().  
>> Change structure of _selectorApplies() to set a result variable and 
>> break rather than retunring immediately.  Inline first level of 
>> recursion (ugly, but it gets the most results).
>>
>>
>> Tests: Silver main.lzx?lzr=dhtml&lzt=html shows a total of 56350 fewer 
>> function calls in firebug (from 307750 to 251400).  Calls to 
>> _selectorApplies() have been reduced from 125068 to 66294 calls.
>>
>> Files:
>> M      WEB-INF/lps/lfc/services/LzCSSStyle.js
>>
>> Changeset: 
>> http://svn.openlaszlo.org/openlaszlo/patches/20070801-maxcarlson-k.tar
> 
> Benjamin Shine
> Software Engineer, Open Laszlo / Laszlo Systems
> ben at laszlosystems.com
> 
> 
> 

-- 
Regards,
Max Carlson
OpenLaszlo.org