[Laszlo-dev] changeset for review: fix for LPP-1888
John Sundman
jsundman at laszlosystems.com
Wed Mar 29 10:39:37 EST 2006
>
I understand that you are just fixing a bug and not incorporating any
new functionality, but I thought this an opportune moment to get you to
look at the docs :^)
I don't know what keywords should be private and which should be
public; that's why I would like you to take a look.
If you look at the reference page for this class, it appears pretty
much useless, as there are no methods on it. When you look in the
source, however, you see lots of methods on it. I just want to make
sure that the docs are correct. Maybe there is a good reason that all
those methods are private -- I'm not in a good position to judge that.
If, after taking a look, you think they should all remain private,
then I'll approve the checkin as is. In fact, I pre-approve, on the
understanding that you'll take a look and make public any methods (n >=
0) that should be made public.
Thanks
jrs
>
> This patch doesn't expose any new functionality, just fixes a bug. But
> I can
> change any private keywords to public if they are supposed to be.
> Which vars
> or functions are you referring to?
More information about the Laszlo-dev
mailing list