[Laszlo-dev] Re: For Review: Change 37778 Summary:Remove
LzView.xscale and LzView.yscale
P T Withington
ptw at laszlosystems.com
Fri Jan 27 12:30:02 PST 2006
On 27 Jan 2006, at 15:04, Jim Grandy wrote:
> On Jan 27, 2006, at 10:46 AM, P T Withington wrote:
>> Given what you said earlier about some components still using x/
>> yscale, I expected to see changes to them too. Am I confused?
> Sorry, I wasn't sufficiently clear. They use stretchResource, which
> turned out to be related but independent.
>> Does the smoketest pass?
> Erp, no. There were some regression tests in all_setters.lzl and
> regression.lzl that referred to xscale/yscale. I've removed those
> -- a simple change, I assume we don't need a review for this.
Fine. Really approved now!
>> If yes to both questions, then approved.
>> On 27 Jan 2006, at 13:28, Jim Grandy wrote:
>>> Change 37778 by jgrandy at jgrandy-dev on 2006/01/25 20:32:31 *pending*
>>> Summary:Remove LzView.xscale and LzView.yscale
>>> Bugs Fixed:LPP-849 LPP-851
>>> Technical Reviewer: ptw (pending)
>>> QA Reviewer: mdavis (pending)
>>> Doc Reviewer: jsundman (pending)
>>> Release Notes: The LzView attributes xscale and yscale were
>>> deprecated in LPS 2.2, but were never removed from the schema or
>>> the code.
>>> It turns out LzView was using them to cache information about
>>> scaling whether or not they had been set. I changed their names
>>> to _xscale
>>> and _yscale and removed the public setters and events.
>>> Affected files ...
>>> ... //depot/lps-dev/WEB-INF/lps/lfc/views/LaszloView.as#36 edit
>>> ... //depot/lps-dev/WEB-INF/lps/schema/lzx.rnc#33 edit
More information about the Laszlo-dev