[Laszlo-dev] Re: For Review: Change 37160 Summary: CodeGenerator in java (finally)

[John Sundman]

HUZZAH! HOORAY!

Congratulations Tucker.  Have yerself a beer.

Approved.

(This approval is contingent on the assumption that there are no  
user-visible changes to this compiler switch.)

jrs



On Jan 17, 2006, at 4:27 PM, P T Withington wrote:

> Change 37160 by ptw at ptw-dev-two on 2006/01/17 13:02:50 *pending*
>
> 	Summary: CodeGenerator in java (finally)
> 	
> 	Bugs Fixed:
> 	LPP-752 'Port compiler to java' (done!)
> 	
> 	Technical Reviewer: hminsky (pending)
> 	QA Reviewer: frisco (pending)
> 	Doc Reviewer: jsundman (pending)
> 	
> 	Documentation: still builds
> 	
> 	Details:
> 	
> 	build.xml: remove dependency on CodeGenerator.py
> 	CodeGenerator.py: delete
> 	jsdoc2xml: insert scaffolding from CodeGenerator.py
> 	lzsc: make Resolver callable from java
> 	CodeGenerator.java: add (lightly tossed from .py with a
> 	smidgeon of type declarations and casts, and a soupcon of OO
> 	the hard way)
> 	Compiler: Simplify imports, remove unused code
> 	InstructionCollector: rename __call__ to make for legibility
> 	Instructions: make ActionNames initialization static, add some
> 	utility functions for boxing ints, protect constructors to
> 	ensure factory is used, add support for testing for
> 	unconditional return/branch, remove Python adapters
> 	VariableReference, MemberReference: __call__ -> make
> 	Reference: clean up type declarations, add utility boxing
> 	functions
> 	Translator: clean up type declarations
> 	VariableAnalyzer: clean up type declarations
> 	
> 	Tests: smokecheck bytes are identical, ant doc works,
> 	compiling is faster
>
> Affected files ...
>
> ... //depot/lps-dev/WEB-INF/lps/server/build.xml#8 edit
> ... //depot/lps-dev/WEB-INF/lps/server/sc/CodeGenerator.py#7 delete
> ... //depot/lps-dev/WEB-INF/lps/server/sc/jsdoc2xml.py#4 edit
> ... //depot/lps-dev/WEB-INF/lps/server/sc/lzsc.py#8 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> CodeGenerator.java#1 add
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> Compiler.java#4 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> InstructionCollector.java#9 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> Instructions.java#12 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> MemberReference.java#1 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> Reference.java#3 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> Translator.java#2 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> VariableAnalyzer.java#1 edit
> ...  
> //depot/lps-dev/WEB-INF/lps/server/src/org/openlaszlo/sc/ 
> VariableReference.java#2 edit
>
>
> <changeset-37160.zip>