[Laszlo-dev] For Review: Change 36782 Summary:Remove all $flasm
code from OLR, default LzNode parent to canvas.
P T Withington
ptw at laszlosystems.com
Fri Jan 6 13:49:01 PST 2006
I want this change in, because it means I can rip out a bunch of
compiler crap and simplify my conversion. Comments:
Adam already commented on the parent change. I think that should be
moved to a separate change anyways, if you want to fight for it.
I'm not convinced you should remove the empty subviews array from
LzView.prototype. The point of it being there was so that subviews
is always an array to save having to check for null in every
iterator. It's not much overhead to have one in the proto. If you
want to clean up the sentinel code where you add to the array, you
could use hasOwnProperty to make sure you only modify your private
array and not the proto array.
parameters will already be in registers, so you don't need to (re-)
declare them as var.
IWBNI to var "__LZOutlie" + axis
In reverseArray, I think is it slightly more efficient to use indices
rather than push (basically you move diddling length out of the
loop), and it may be a teeny bit more efficient to make the target
array the right size to start with, rather than it having to grow as
you add elements. (There is some info on this in the performance
chapter, I believe).
On 6 Jan 2006, at 13:52, Jim Grandy wrote:
> Change 36782 by jgrandy at jgrandy-dev on 2006/01/06 10:44:12 *pending*
> Summary:Remove all $flasm code from OLR, default LzNode parent to
> New Features:LzNode's parent now defaults to the canvas, rather
> than null.
> Bugs Fixed:LPP-350 LPP-1271
> Technical Reviewer: ptw (pending)
> QA Reviewer: mdavis (pending)
> Doc Reviewer: jsundman (pending)
> Release Notes:The OLR no longer contains any $flasm code. When no
> parent is given for an LzNode, the canvas is now substituted.
> Tests:smokecheck, Laszlo Explorer
> Affected files ...
> ... //depot/lps-dev/WEB-INF/lps/lfc/core/LzNode.as#25 edit
> ... //depot/lps-dev/WEB-INF/lps/lfc/events/LaszloEvents.as#13 edit
> ... //depot/lps-dev/WEB-INF/lps/lfc/services/LzInstantiator.as#8 edit
> ... //depot/lps-dev/WEB-INF/lps/lfc/views/LaszloView.as#33 edit
> Laszlo-dev mailing list
> Laszlo-dev at openlaszlo.org
More information about the Laszlo-dev