[Laszlo-dev] For your review: capsule and capsulebutton [was Re: For your review: Lock layouts until parent view (and its children) are done initing]

[Benjamin Shine]

stylishbutton and custombutton are in lps-pave's incubator. I don't  
know how to do that integration; it should be very safe, though.

capsulebutton is a new creation trying to match Peter Andrea's  
gorgeous asset-based buttons with drawviews. They're not perfect, but  
they're close.

Change 36788 by ben at ben-linux-builder on 2006/01/06 11:07:46 *pending*

         New Features: Added two classes to draw a simple and  
complicated fake 3D capsule,
         and buttons based on those classes.
         Tests:
         There's a separate test file for each new class: test- 
capsule.lzx, test-simplecapsule.lzx, test-capsulebutton.lzx, test- 
simplecapsulebutton.lzx
         Release Notes: The colors and attributes on these buttons  
are okay but not yet totally great.

Affected files ...

... //depot/lps-dev/lps/components/incubator/capsule.lzx#1 add
... //depot/lps-dev/lps/components/incubator/capsulebutton.lzx#1 add
... //depot/lps-dev/lps/components/incubator/simplecapsule.lzx#1 add
... //depot/lps-dev/lps/components/incubator/ 
simplecapsulebutton.lzx#1 add
... //depot/lps-dev/lps/components/incubator/test/test-capsule.lzx#1 add
... //depot/lps-dev/lps/components/incubator/test/test- 
capsulebutton.lzx#1 add
... //depot/lps-dev/lps/components/incubator/test/test- 
simplecapsule.lzx#1 add
... //depot/lps-dev/lps/components/incubator/test/test- 
simplecapsulebutton.lzx#1 add

-------------- next part --------------
A non-text attachment was scrubbed...
Name: changeset-36788.zip
Type: application/zip
Size: 11197 bytes
Desc: not available
Url : http://openlaszlo.org/pipermail/laszlo-dev/attachments/20060106/b33dc8b7/changeset-36788.zip
-------------- next part --------------


On Jan 6, 2006, at 10:46 AM, Max Carlson wrote:

> The change is in.  Let me know if it helps emerald.  Calendar and  
> dashboard are nice 'n snappy.
>
> As Jim said, this is one of those things you realize should have  
> been done years ago...
>
> One thing: /test/layout-perf-tests/ is missing the capsule, stylish  
> and custom button implementations.  Can you fix that (check in  
> copies with the test I suppose for now...)
>
> Thanks for pointing this out!
>
> -Max
>
> P.S.  Any way I could entice you guys to migrate the css changes  
> from pave over to lps-dev?  I'd like to get them out into the  
> community at large...  I'm happy to help where I can here but I  
> don't know the css codebase nearly as well as you :)
>
> Benjamin Shine wrote:
>> OH MY GOD that's an amazing improvement.
>> I don't think I have privileges to approve changes to the  
>> platform  though.
>> Once it's in, we should integrate it over to pave and see how it   
>> kicks emerald's ass!
>> On Jan 6, 2006, at 10:14 AM, Max Carlson wrote:
>>> I'm seeing a more than 10x startup time improvement in Ben's  
>>> test  case with this change.  Please review and let's get it  
>>> checked in!
>>>
>>> -Max
>>> <changeset-36777.zip>
>