[Laszlo-dev] [Updated] For Review: Change 20061208-ptw-v Summary: Purge old <attribute name="on..." value="null" /> declarations

[Max Carlson]

P T Withington wrote:
> [Updated -- actually compiles now]
> 
> Change 20061208-ptw-v by ptw at dueling-banjos.local on 2006-12-08 17:52:25 
> EST
>     in /Users/ptw/OpenLaszlo/legals-1
> 
> Summary: Purge old <attribute name="on..." value="null" /> declarations
> 
> Bugs Fixed:
> LPP-3248 'CompileAttribute should not be getting called on event handlers.'
> 
> Technical Reviewer: hminsky (pending)
> QA Reviewer: max (pending)
> Doc Reviewer: jsundman (pending)
> 
> Release Notes:
> We formerly recommended the idiom:
> 
>   <attribute name="on..." value="null" />
> 
> as a way to document events that your class will send.  This is no
> longer valid and will generate a compiler warning.  You should use:
> 
>   <event name="on..." />
> 
> in the future.
> 
> Details:
>     lps/components/**:  replace old idiom
> 
>     basecomponent: don't try to register when style is set to null
>     (silences zillions of errors in test case).
> 
>     NodeModel: replace error with more descriptive warning.
> 
> Tests:
>     test/components/style_example.lzx?lzr=dhtml no longer triggers a
>     stack trace.
> 
> Files:
> M      lps/components/rpc/ajax.lzx
> M      lps/components/rpc/rpc.lzx
> M      lps/components/incubator/scrolledittext.lzx
> M      lps/components/incubator/baseedittext.lzx
> M      lps/components/incubator/baseradio.lzx
> M      lps/components/incubator/rich-text/scrollrichedittext.lzx
> M      lps/components/base/basecomponent.lzx
> D      test/components/lz/tree.lzx
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061208-ptw-v.tar

style_example.lzx fails to run for me - I get this error:

this.ondata has no properties

which happens on line 6900:

6897return false
6898}
6899if(this.__LZdchanged){
6900this.ondata.sendEvent(this.data)
6901this.__LZdchanged=false
6902}



-- 
Regards,
Max Carlson
OpenLaszlo.org