[Laszlo-dev] For Review: Change 20061202-ptw-G Summary: Move the LFC

[Max Carlson]

P T Withington wrote:
> Change 20061202-ptw-G by ptw at dueling-banjos.local on 2006-12-02 10:57:23 
> EST
>     in /Users/ptw/OpenLaszlo/legals-2
> 
> Summary: Move the LFC
> 
> New Features: The LFC libraries are now stored in lps/includes so that
> all apps can share the same LFC in the browser cache.  The location
> can be configured by setting compiler.runtime.dir in lps.properties.
> 
> Bugs Fixed:
> LPP-3081 'LFC url prevents client sharing'
> 
> Technical Reviewer: max, ben (pending)
> QA Reviewer: henry (pending)
> Doc Reviewer: jsundman (pending)
> 
> Details:
> 
>     lfc/build.xml: Reworked how this is implemented to get
>     dependencies right.  Now all LFC flavors depend on the sources
>     (and on the script compiler sources, so the LFC will be re-built
>     if the script compiler is modified) and will be deleted in init if
>     they are out of date.  The lfcs target now iterates through the
>     runtimes and flavors and builds each one that is requested but
>     which does not exist.  (The old code only checked dependencies on
>     a few hard-wired flavors, so you could get in a situation where it
>     would always think the LFC was out of date.)  Also now builds the
>     LFC flavors to the lps.properties compiler.runtime.dir.
> 
>     lps.properties:  new property compiler.runtime.dir, defaults to
>     lps/includes/lfc
> 
>     LPS.java: update getLFCDirectory to respect compiler.runtime.dir,
>     add getLFCname to centralize computation of LFC flavor name,
>     remove krank kruft.
> 
>     ResponderLFC.java: use LPS.getLFCname, LPS.getLFCDirectory.
> 
>     CanvasCompiler.java: communicate setting of profile to
>     compiler/Canvas.java
> 
>     ToplevelCompiler.java: use LPS.getLFCname
> 
>     SWFWriter.java: Don't pass bogus base to FileResolver (which caused
>     the file resolver to always search '/'), remove krank kruft.
> 
>     FileResolver.java: null base means there is no base to look in,
>     not that you should search '/'.
> 
>     Canvas.java: accept profile setting, add lfc location to getXML
>     info.
> 
>     dhtml-demo-response.xslt, demo-build-lfc, kranking.xslt,
>     krank-abort.xslt, embed.js: Obsolete, deleted.
> 
>     embed-compressed.js: this is now built from sources, deleted
> 
>     html-response.xslt: Pass /canvas/@lfc to dhtmlEmbedLFC.
> 
>     embednew.js: Move to source, update dhtmlEmbedLFC to just load the
>     url it is given.  Simplify browser version regexps.
> 
>     embed-library.lzs: Library to compress to embed-compressed.js
> 
>     flash.js: Move to source, replace literal RegExp's so they can
>     pass our compiler (for compression).
> 
>     source/build.xml: How to build embed-compressed.js from
>     embed-library.lzs
> 
>     build.xml: LFC's come from lps/include now, call the build file to
>     build embed-compressed.js
> 
> Tests:
>     calendar demo still works in both runtimes
> 
> Files:
> M      WEB-INF/lps/lfc/build.xml
> M      WEB-INF/lps/config/lps.properties
> M      WEB-INF/lps/server/src/org/openlaszlo/server/LPS.java
> M      
> WEB-INF/lps/server/src/org/openlaszlo/servlets/responders/ResponderLFC.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/CanvasCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/SWFWriter.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/FileResolver.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/Canvas.java
> D      WEB-INF/lps/templates/dhtml-demo-response.xslt
> M      WEB-INF/lps/templates/html-response.xslt
> D      WEB-INF/lps/templates/kranking.xslt
> D      WEB-INF/lps/templates/krank-abort.xslt
> D      lps/includes/embed.js
> D      lps/includes/embed-compressed.js
> A  +   lps/includes/source/embednew.js
> A      lps/includes/source/embed-library.lzs
> A  +   lps/includes/source/flash.js
> A      lps/includes/source/build.xml
> D      lps/includes/embednew.js
> D      lps/includes/lfc/demo-buildlfc
> D      lps/includes/flash.js
> M      build.xml
> 
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20061202-ptw-G.tar

Approved!  I just sent you a change for review that makes wrapper pages 
work again in TOT DHTML.  Please check it in with your change.  This 
looks really great!

-- 
Regards,
Max Carlson
OpenLaszlo.org