[Laszlo-dev] For Review: LPP-2559, LPP-2499, LPP-2500, LPP-2496, LPP-2249

[Benjamin Shine]

Nice detailed checkin comments -- but it looks like you're using old- 
style changesets. Now that we're in subversion, the tools to make a  
change package for review have changed.
See http://svn.openlaszlo.org/tools/trunk/svn/README.txt which  
describes it all.
Basically the tools just send the diffs, which are easier to review,  
sort of.
They don't handle file deletion well, though.

-ben

On Aug 28, 2006, at 12:00 PM, J Crowley wrote:

> Change:	New
>
> Date:	2006/08/27 15:00:00
>
> Client:	
>
> User:	
>
> Status:	pending
>
> Description:
> 	Summary: defaultchartstyle includes references to undefined
> 			 	font "myverity";
> 			 legenditem has typeo in a nested <text> @font;
> 			 comment out or remove all Debug.write()s from
> 			 	Charting & Graphing code.;
> 			 Dataseries component does not work with null or
> 			 	single results;
> 			 Various Charting and Graphing Bugs;
> 	
> 	Bugs Fixed: LPP-2559, LPP-2499, LPP-2500, LPP-2496,
> 		LPP-2249
> 	
> 	Technical Reviewer: Garth Smedley
> 	QA Reviewer:
> 	Doc Reviewer:
> 	
> 	Documentation: Bret and I fixed various bugs in Charting
> 		and Graphing, and as these bugs were all in the same
> 		files, and in the same files as other bugs that have
> 		already been filed that I'd been in the middle of
> 		fixing, and some fixes were reliant on other fixes,
> 		I figured the best way to submit them was all in one
> 		package.
>
> 	Details:
>
> 	common/dataseries.lzx: Made changes to eliminate errors
> 		when a user tries to use null or single data.  Numerous
> 		other problems were fixed as we found them.
> 	common/horizontalaxis.lzx: Fixed some positioning issues
> 		and other bugs were immediately corrected upon discovery.
> 	common/legend.lzx: Several bugs were corrected upon
> 		discovery.
> 	common/rectangularchart.lzx: Fixed problem with rightMargin
> 		not actually having any effect.  Fixed subsequent problems
> 		that resulted from fixing rightMargin.  Added ability to
> 		draw banding.  Fixed numerous other errors and issues.
> 	common/chart.lzx: Several bugs were corrected upon discovery.
> 	common/viewspoolmanager.lzx: Several bugs and debugger warnings
> 		that were corrected upon discovery.
> 	common/virtualdrawview.lzx: Several minor bugs fixed and some
> 		visual elements polished.
> 	common/datamarker.lzx: Created new point shapes, fixed issues
> 		with 'stroke', fixed other bugs as they were encountered.
>
> 	styles/defaultchartstyle.lzx: Made a few changes to accomodate
> 		the new features (banding, pointstyles, stroke, etc).
> 	styles/defaultchartstyle.xml: Fixed LPP-2496
> 	styles/chartstyle.lzx: Made a few changes to accomodate
> 		the new features (banding, pointstyles, stroke, etc).
>
> 	Tests: Created a test chart and noted an absence of
> 		Debug.write()s and warnings and errors, and the presence
> 		of functionality in things that were broken.
>
> 	Files:
>
> 	//common/dataseries.lzx				# edit
> 	//common/horizontalaxis.lzx			# edit
> 	//common/legend.lzx					# edit
> 	//common/rectangularchart.lzx		# edit
> 	//common/chart.lzx					# edit
> 	//common/viewspoolmanager.lzx		# edit
> 	//common/virtualdrawview.lzx		# edit
> 	//common/datamarker.lzx				# edit
> 	//styles/defaultchartstyle.lzx		# edit
> 	//styles/defaultchartstyle.xml		# edit
> 	//styles/chartstyle.lzx				# edit
> <LPP-2559 2499 2500 2496 2249.zip>
> _______________________________________________
> Laszlo-dev mailing list
> Laszlo-dev at openlaszlo.org
> http://www.openlaszlo.org/mailman/listinfo/laszlo-dev