[Laszlo-dev] For Review: Change change.ifjda2232.txt Summary: Cleanup LFC warnings in data directory

P T Withington ptw at openlaszlo.org
Thu Aug 24 17:25:43 EDT 2006


Has LazyReplicationManager not been converted to the new class syntax?

When is searchParents and __LZupdateShown not in the immediate  
parent?  Is this a missing interface on View or something else.   
Seems odd to me.

I guess if you declare childNodes in View, you still need to test  
whether it is an array or not.  But `if (d.childNodes)` is probably  
still more efficient than `if ('childNodes' in d)`.

Feel free to make temp vars to hold long expressions that are used  
repeatedly:

   var dc1 = d.childNodes[1]

the compiler is too stupid to do it for you (think C circa 1975).

I don't understand the commented out line added to LzDataAttrBind.

Otherwise, approved.

On 2006-08-24, at 16:49 EDT, Philip Romanik wrote:

> (Tucker, there are two changes to fix variable overriding in a  
> derived class.)
>
> Change change.ifjda2232.txt by Philip at Philip-DC /tmp/ on 2006-08-24  
> 16:16:19 EDT
>
> Summary: Cleanup LFC warnings in data directory
>
> New Features:
>
> Bugs Fixed: LPP-2034 (partially)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>
> Tests:
> lzpix
>
> Files:
> M      LzLazyReplicationManager.lzs
> M      LzDatapointer.lzs
> M      LzDataset.lzs
> M      LzDatapath.lzs
> M      LzHTTPDatasource.lzs
> M      LzDatasource.lzs
> M      LzDataAttrBind.lzs
> <patch.Philip.6044.tgz>



More information about the Laszlo-dev mailing list